这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Fix dataset search #687

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Fix dataset search #687

merged 4 commits into from
Aug 5, 2020

Conversation

@IonesioJunior
Copy link
Member

@IonesioJunior IonesioJunior commented Aug 5, 2020 •
edited
Loading

Description

  • During the model-centric/data-centric rename PR the network endpoints were not updated. So the network app was trying to reach the /search node endpoint (which is now /data-centric/search).
  • The missing argument during network node initialization. So the nodes were not registering their addresses in the desired network.

How has this been tested?

  • Build docker images (node/network)
  • Register datasets using ModelCentricFLClient
  • Search for the datasets using the PublicGridNetwork class

Checklist

@IonesioJunior IonesioJunior added Type: Bug 🐛 Some functionality not working in the codebase as intended Severity: 2 - High 😰 Does not cause a failure, but causes the system to be incorrect, incomplete, or inconsistent Priority: 1 - Immediate 🔥 Must be fixed immediately and cannot wait labels Aug 5, 2020
@IonesioJunior IonesioJunior marked this pull request as ready for review August 5, 2020 18:17
@IonesioJunior IonesioJunior changed the title [WIP] Fix dataset search Fix dataset search Aug 5, 2020
@IonesioJunior IonesioJunior requested review from a team and jmaunon August 5, 2020 18:17
jmaunon
jmaunon approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@jmaunon jmaunon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmaunon jmaunon merged commit 048be4a into dev Aug 5, 2020
@jmaunon jmaunon deleted the fix_dataset_search branch August 5, 2020 21:04
AmrMKayid added a commit that referenced this pull request Aug 14, 2020
@AmrMKayid
Merge branch 'dev' into abstract-core-classes
cd2551b 
* dev:
  [WIP] Update default ports (#691)
  Improve websocket performance (#690)
  Create Group model in Node DB (#688)
  Fix dataset search (#687)
  Add support for FSS online key generation for data centric workers (#686)
  Create User model in Network DB (#683)
  Create Role model in Node DB (#684)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmaunon jmaunon jmaunon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Priority: 1 - Immediate 🔥 Must be fixed immediately and cannot wait Severity: 2 - High 😰 Does not cause a failure, but causes the system to be incorrect, incomplete, or inconsistent Type: Bug 🐛 Some functionality not working in the codebase as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IonesioJunior @jmaunon