fixed drupal connector #3893
Merged
fixed drupal connector #3893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3875 (comment)
Pull Request Type
Relevant Issues
resolves #3875
What is in this change?
This pull request simplifies the handling of token count estimation in the
DrupalWikiclass by removing unnecessary conditional logic and directly computing the token count where it is used.Code simplification:
tokenCountvariable and its associated conditional logic for calculating token count, simplifying the code by directly callingtokenizeString(page.processedBody)in thetoken_count_estimateproperty. (collector/utils/extensions/DrupalWiki/DrupalWiki/index.js, [1] [2]Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes