LMStudio 0 value embeddings patch #4084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where LMStudio embedding calls returned all-zero vectors by explicitly requesting a base64 encoding format.
- Adds
encoding_format: "base64"to the LMStudio embedder.create()call. - No other functional changes introduced.
Comments suppressed due to low confidence (2)
server/utils/EmbeddingEngines/lmstudio/index.js:66
- Add a comment above this line explaining why the
encoding_formatparameter is necessary to address the zero-value embeddings issue.
encoding_format: "base64",
server/utils/EmbeddingEngines/lmstudio/index.js:66
- Add unit tests to verify that embeddings are correctly base64-encoded when this parameter is included, ensuring the fix works as intended.
encoding_format: "base64",
| @@ -63,6 +63,7 @@ class LMStudioEmbedder { | |||
| .create({ | |||
| model: this.model, | |||
| input: chunk, | |||
| encoding_format: "base64", | |||
| }) | |||
| .then((result) => { | |||
There was a problem hiding this comment.
Consider chaining a .catch() handler to this promise to handle potential API errors and avoid unhandled promise rejections.
Copilot uses AI. Check for mistakes.
cabwds
pushed a commit
to cabwds/anything-llm
that referenced
this pull request
Jul 3, 2025
patch lmstudio encoding_format to fix all embeddings as 0 value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #4080
What is in this change?
"encoding_format" : "base64"to the LMStudio backend via the OpenAI packageAdditional Information
anything-llm/server/utils/vectorDbProviders/lance/index.js
Line 128 in 07129e8
Developer Validations
yarn lintfrom the root of the repo & committed changes