这是indexloc提供的服务，不要输入任何密码
Skip to content

SQL preflight connection validation #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 16, 2025
Merged

SQL preflight connection validation #4150

merged 7 commits into from
Jul 16, 2025

Conversation

shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Jul 15, 2025 •
edited
Loading

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #4149

What is in this change?

  • Adds preflight validation to SQL agent configurations
  • Validate connection string on NewConnectionModal save
  • Allows users to continue editing connection config on failed connection
  • Improves UX of SQL agent setup

Additional Information

Tested On:

  • MSSQL (including encryption)
  • PostgreSQL
  • MySQL

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 self-assigned this Jul 15, 2025
@shatfield4 shatfield4 linked an issue Jul 15, 2025 that may be closed by this pull request
[FEAT]: SQL Preflight connections #4149
Closed
@shatfield4 shatfield4 marked this pull request as ready for review July 15, 2025 20:01
@shatfield4 shatfield4 added the PR:needs review Needs review by core team label Jul 15, 2025
@timothycarambat timothycarambat merged commit 49ea545 into master Jul 16, 2025
@timothycarambat timothycarambat deleted the 4149-feat-sql-preflight-connections branch July 16, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels
PR:needs review Needs review by core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: SQL Preflight connections
2 participants
@shatfield4 @timothycarambat