-
-
Notifications
You must be signed in to change notification settings - Fork 558
Update Slovakia holidays: additional holidays moved to WORKDAY
for 2026
#3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughImplements 2026-specific exceptions in Slovakia holiday rules: excludes two public holidays for 2026 and reclassifies them as WORKDAY holidays, adds year-bounded logic tied to Laws 530/2023, 326/2020, and 261/2025, updates references, and aligns tests to validate public vs. workday classification. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (6)📚 Learning: 2025-09-14T04:41:10.139Z
Applied to files:
📚 Learning: 2025-05-06T21:07:11.577Z
Applied to files:
📚 Learning: 2025-04-05T04:47:27.213Z
Applied to files:
📚 Learning: 2025-05-09T18:36:09.607Z
Applied to files:
📚 Learning: 2025-09-14T17:17:14.387Z
Applied to files:
📚 Learning: 2025-09-20T12:21:50.877Z
Applied to files:
🧬 Code graph analysis (2)holidays/countries/slovakia.py (1)
tests/countries/test_slovakia.py (1)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3005 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 306 306
Lines 18072 18076 +4
Branches 2332 2334 +2
=========================================
+ Hits 18072 18076 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇸🇰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed change
Update Slovakia holidays: additional holidays moved to
WORKDAY
for 2026 (May 8 and Sep 16).Type of change
holidays
functionality in general)Checklist
make check
locally; all checks and tests passed.