+
Skip to content

Update Slovakia holidays: move "Struggle for Freedom and Democracy Day" to WORKDAY category for 2025 onwards #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Update Slovakia holidays: move "Struggle for Freedom and Democracy Day" to WORKDAY category for 2025 onwards #3004

merged 1 commit into from
Oct 13, 2025

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 13, 2025 •
edited
Loading

Proposed change

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@github-actions github-actions bot added the test label Oct 13, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 13, 2025 •
edited
Loading

Summary by CodeRabbit

  • New Features

    • Updated Slovakia holiday rules: Nov 17 (Struggle for Freedom and Democracy Day) is a public holiday only from 2001–2024; from 2025 it is treated as a workday holiday. Holiday listings now reflect this year-based distinction.

  • Documentation

    • Added an additional reference link for Slovakia public holidays.

  • Tests

    • Expanded and standardized year-range coverage for Slovakia, including 2025, and clarified public vs. workday holiday expectations.

Walkthrough

Updates Slovakia holiday rules: adds a reference URL, restricts Nov 17 public holiday to 2001–2024, and adds a workday holiday on Nov 17 from 2025. Tests refactor to use a centralized full_range and adjust expectations for public vs workday holidays, including 2025 coverage and renamed tests.

Changes

Cohort / File(s) Summary of changes
Slovakia holiday rules
holidays/countries/slovakia.py		 Added reference URL. Constrained Nov 17 public holiday to years 2001–2024. Introduced Nov 17 as a workday holiday starting 2025. No signature changes.
Tests refactor and expectations
tests/countries/test_slovakia.py		 Centralized year range via full_range (1993–2050). Updated assertions to use the range. Included 2025 cases. Clarified public vs workday holiday checks. Renamed tests to reflect contexts and removed a long-running single-year assertion.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

l10n

Suggested reviewers

  • arkid15r
  • KJhellico

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly reflects the main change by specifying that Slovakia’s Struggle for Freedom and Democracy Day is moved to the WORKDAY category from 2025 onwards and directly references the affected holiday and timeframe. It focuses on the primary update without including irrelevant details or noise. This concise phrasing allows a teammate scanning history to immediately grasp the core change.
Description Check ✅ Passed The pull request description specifies moving Slovakia’s Struggle for Freedom and Democracy Day to the WORKDAY category from 2025 onwards and mentions modernizing the test cases, directly reflecting the code changes summarized.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (181aad4) to head (034bf8a).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #3004   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       305           
  Lines        18039     18041    +2     
  Branches      2329      2330    +1     
=========================================
+ Hits         18039     18041    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico
KJhellico approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

arkid15r
arkid15r reviewed Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Oct 13, 2025
Merged via the queue into vacanza:dev with commit 66a5f43 Oct 13, 2025
36 checks passed
@PPsyrius PPsyrius deleted the slovakia_2025 branch October 14, 2025 02:45
@coderabbitai coderabbitai bot mentioned this pull request Oct 14, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载