+
Skip to content

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Philippines holidays: add 2026 holidays according to Presidential Proclamation.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Summary by CodeRabbit

  • New Features
    • Philippines: Added 2026 special non-working days — All Souls’ Day (Nov 2) and Christmas Eve (Dec 24). Standardized “Christmas Eve” label across 2025–2026 entries.
  • Localization
    • Updated translations for en_PH, en_US, Filipino, and Thai locales; added entries for “Christmas Eve” and “All Souls’ Day.”
  • Documentation
    • Added a new proclamation reference to the Philippines holiday description.
  • Tests
    • Expanded Philippines holiday tests for 2026, including special days and Chinese New Year expectations.

Walkthrough

Adds a Christmas Eve constant and references it in Philippines special-public-holidays for 2025–2026, introduces All Souls' Day (2026-11-02), updates locale translation files and snapshots, and adjusts tests to include the new 2026 dates.

Changes

Cohort / File(s) Summary of changes
PH holiday logic
holidays/countries/philippines.py
Added christmas_eve = tr("Christmas Eve"); updated special_public_holidays to use christmas_eve for 2025-12-24 and 2026-12-24; added 2026-11-02 → All Souls' Day; updated class docstring with Proclamation No. 1006/2025.
Localization (PH)
holidays/locale/en_PH/LC_MESSAGES/PH.po, holidays/locale/en_US/LC_MESSAGES/PH.po, holidays/locale/fil/LC_MESSAGES/PH.po, holidays/locale/th/LC_MESSAGES/PH.po
Bumped metadata; added/adjusted translation units for “Christmas Eve” and “All Souls' Day”; removed/merged duplicate blocks where applicable.
Snapshots
snapshots/countries/PH_COMMON.json
Added 2026-11-02All Souls' Day and 2026-12-24Christmas Eve.
Tests
tests/countries/test_philippines.py
Updated expectations to include 2026 special days (2026-11-02, 2026-12-24) and added 2026-02-17 for Chinese New Year checks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • arkid15r
  • PPsyrius

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely describes the main change—updating the Philippines holidays with the addition of 2026 dates—and is directly related to the content of the pull request without extraneous details.
Description Check ✅ Passed The pull request description accurately outlines the update to the Philippines holiday calendar, references the Presidential Proclamation, and is clearly connected to the changes in the code and translation files.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Ruff (0.12.2)
holidays/countries/philippines.py

�[1;31mruff failed�[0m
�[1mCause:�[0m Failed to load configuration /ruff.toml
�[1mCause:�[0m Failed to parse /ruff.toml
�[1mCause:�[0m TOML parse error at line 26, column 3
|
26 | "RSE100", # Use of assert detected
| ^^^^^^^^
Unknown rule selector: RSE100

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a84ec9 and bef9cdd.

📒 Files selected for processing (1)
  • holidays/countries/philippines.py (3 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: PPsyrius
PR: vacanza/holidays#2489
File: holidays/countries/sao_tome_and_principe.py:22-26
Timestamp: 2025-04-23T14:55:35.504Z
Learning: References in holidays classes should only be included if they're used for test case cross-checks or provide historical context about when holidays were added/removed, not just for the sake of having more references.
Learnt from: PPsyrius
PR: vacanza/holidays#2489
File: holidays/countries/sao_tome_and_principe.py:22-26
Timestamp: 2025-04-23T14:55:35.504Z
Learning: References in holidays classes should only be included if they're used for test case cross-checks or provide historical context about when holidays were added/removed, not just for the sake of having more references.
Learnt from: PPsyrius
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:146-159
Timestamp: 2025-03-19T16:54:58.657Z
Learning: In the holidays library implementation, explicit holiday dates (like Diwali in Fiji) are only defined for historical years with official sources (2016-2025). Future dates beyond the explicitly defined range are automatically calculated by methods like `_add_diwali`, which provide approximations when official dates aren't yet available.
📚 Learning: 2025-09-10T03:46:34.484Z
Learnt from: PPsyrius
PR: vacanza/holidays#2912
File: holidays/countries/philippines.py:56-56
Timestamp: 2025-09-10T03:46:34.484Z
Learning: Lawphil doesn't always immediately include the latest proclamations - verify links exist before suggesting them as alternatives to Official Gazette references for Philippines holidays.

Applied to files:

  • holidays/countries/philippines.py
📚 Learning: 2025-08-21T04:56:03.780Z
Learnt from: PPsyrius
PR: vacanza/holidays#2843
File: holidays/countries/burundi.py:63-101
Timestamp: 2025-08-21T04:56:03.780Z
Learning: In the holidays library, countries with localization support consistently use tr() wrappers around holiday names when calling _add_* methods (e.g., self._add_new_years_day(tr("Holiday Name"))). This is the established pattern across United States, Thailand, and other l10n-enabled countries, contrary to any suggestion that translation is handled internally by _add_* methods.

Applied to files:

  • holidays/countries/philippines.py
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Test build on ubuntu-latest
  • GitHub Check: Test build on macos-latest
  • GitHub Check: Test build on windows-latest
  • GitHub Check: Test docs build
🔇 Additional comments (2)
holidays/countries/philippines.py (2)

244-244: No-op whitespace.

Nothing to do.


248-250: Good extraction: centralized, localized Christmas Eve label.

Consistent with l10n patterns in this repo.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3be8c80) to head (bef9cdd).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2912   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          295       295           
  Lines        17518     17519    +1     
  Branches      2267      2267           
=========================================
+ Hits         17518     17519    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3be8c80 and 7a84ec9.

📒 Files selected for processing (7)
  • holidays/countries/philippines.py (3 hunks)
  • holidays/locale/en_PH/LC_MESSAGES/PH.po (2 hunks)
  • holidays/locale/en_US/LC_MESSAGES/PH.po (2 hunks)
  • holidays/locale/fil/LC_MESSAGES/PH.po (2 hunks)
  • holidays/locale/th/LC_MESSAGES/PH.po (2 hunks)
  • snapshots/countries/PH_COMMON.json (1 hunks)
  • tests/countries/test_philippines.py (2 hunks)
🧰 Additional context used
🧠 Learnings (23)
📓 Common learnings
Learnt from: PPsyrius
PR: vacanza/holidays#2354
File: holidays/countries/fiji.py:146-159
Timestamp: 2025-03-19T16:54:58.657Z
Learning: In the holidays library implementation, explicit holiday dates (like Diwali in Fiji) are only defined for historical years with official sources (2016-2025). Future dates beyond the explicitly defined range are automatically calculated by methods like `_add_diwali`, which provide approximations when official dates aren't yet available.
Learnt from: PPsyrius
PR: vacanza/holidays#2537
File: tests/countries/test_finland.py:23-26
Timestamp: 2025-05-09T18:36:09.607Z
Learning: The holidays project prioritizes complete historical coverage in tests, verifying holidays from their first year of observance (e.g., 1853 for Finland) through future projections, rather than using shorter sliding windows.
📚 Learning: 2025-04-05T04:47:27.213Z
Learnt from: PPsyrius
PR: vacanza/holidays#2416
File: tests/countries/test_turkmenistan.py:52-64
Timestamp: 2025-04-05T04:47:27.213Z
Learning: For holiday tests in the vacanza/holidays project, structure tests by individual holidays rather than by years. Each test method should focus on a specific holiday and test it across multiple years (from start_year through 2050) using helper methods like `assertHolidayName`. For fixed holidays, use generators like `(f"{year}-01-01" for year in range(1991, 2051))`. For movable holidays, specify individual dates for specific years followed by a range check.

Applied to files:

  • tests/countries/test_philippines.py
📚 Learning: 2025-04-05T06:49:06.217Z
Learnt from: PPsyrius
PR: vacanza/holidays#2386
File: tests/countries/test_nepal.py:499-536
Timestamp: 2025-04-05T06:49:06.217Z
Learning: In the holidays project, test files follow a dual testing approach: individual methods test specific holidays across multiple years, while comprehensive year-specific tests (e.g., `test_2025`) verify all holidays for a specific year in a single assertion. Both approaches serve different testing purposes and complement each other.

Applied to files:

  • tests/countries/test_philippines.py
📚 Learning: 2025-05-06T21:07:11.577Z
Learnt from: KJhellico
PR: vacanza/holidays#2530
File: tests/countries/test_andorra.py:23-28
Timestamp: 2025-05-06T21:07:11.577Z
Learning: In the holidays project, test methods for country holidays follow a standard form where year ranges are explicitly recreated in each test method rather than being stored as class variables, to maintain consistency across all country tests.

Applied to files:

  • tests/countries/test_philippines.py
📚 Learning: 2025-07-02T18:17:53.342Z
Learnt from: KJhellico
PR: vacanza/holidays#2608
File: tests/countries/test_saint_vincent_and_the_grenadines.py:162-178
Timestamp: 2025-07-02T18:17:53.342Z
Learning: In the Saint Vincent and the Grenadines holidays implementation, New Year's Day is added without observed rules using `_add_new_years_day()` and should not include observed rule testing in its test method. Only holidays explicitly wrapped with `_add_observed()` have observed behavior.

Applied to files:

  • tests/countries/test_philippines.py
📚 Learning: 2025-09-03T14:05:10.592Z
Learnt from: PPsyrius
PR: vacanza/holidays#2881
File: tests/countries/test_aruba.py:77-79
Timestamp: 2025-09-03T14:05:10.592Z
Learning: The assertNoHolidayName helper method in the vacanza/holidays test framework accepts both individual years (scalars) and iterables of years, making calls like assertNoHolidayName(name, AW.start_year, range(2023, 2050)) valid where AW.start_year is a single integer year.

Applied to files:

  • tests/countries/test_philippines.py
📚 Learning: 2025-06-28T10:39:19.185Z
Learnt from: KJhellico
PR: vacanza/holidays#2684
File: holidays/locale/it/LC_MESSAGES/SM.po:13-13
Timestamp: 2025-06-28T10:39:19.185Z
Learning: In the holidays project, .po file header comments use the format "# [Country] holidays." for default language files (without trailing hash) and "# [Country] holidays [locale] localization." for non-default language files (also without trailing hash).

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-06-26T15:34:35.476Z
Learnt from: KJhellico
PR: vacanza/holidays#2676
File: holidays/locale/en_US/LC_MESSAGES/TN.po:17-28
Timestamp: 2025-06-26T15:34:35.476Z
Learning: In the holidays project, .po file header metadata updates (version numbers, revision dates, translator information) are legitimate changes when part of localization work and don't require `make l10n` regeneration. The `make l10n` command is primarily for formatting fixes and missing translator comments, not for intentional metadata updates.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-05-06T15:25:44.333Z
Learnt from: KJhellico
PR: vacanza/holidays#2530
File: holidays/locale/ca/LC_MESSAGES/AD.po:31-40
Timestamp: 2025-05-06T15:25:44.333Z
Learning: In the Holidays project, msgid fields in localization files contain strings in the entity's default language (as defined by default_language attribute), not English source strings as in standard gettext implementations.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-03-30T18:25:07.087Z
Learnt from: KJhellico
PR: vacanza/holidays#2388
File: holidays/locale/en_CI/LC_MESSAGES/CI.po:88-88
Timestamp: 2025-03-30T18:25:07.087Z
Learning: In the holidays library, localization files have a specific structure: message comments are in standard English (en_US) describing the holiday, while actual translations (msgstr) should use the locale-specific terminology (e.g., en_CI for Ivory Coast English). For example, "Night of Power" in standard English is translated as "Lailatou-Kadr" in Ivory Coast English.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-03-05T17:51:00.633Z
Learnt from: KJhellico
PR: vacanza/holidays#2259
File: holidays/locale/en_IN/LC_MESSAGES/IN.po:30-299
Timestamp: 2025-03-05T17:51:00.633Z
Learning: In the Holidays project, .po files for a country's default locale use empty msgstr fields as a standard convention.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-06-11T18:32:25.595Z
Learnt from: ankushhKapoor
PR: vacanza/holidays#2601
File: holidays/locale/en_MN/LC_MESSAGES/MN.po:13-14
Timestamp: 2025-06-11T18:32:25.595Z
Learning: For non-default locale `.po` files, the header comment format is:
`# <Country> holidays <locale> localization.` (no trailing hash).

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-06-29T09:37:35.283Z
Learnt from: KJhellico
PR: vacanza/holidays#2687
File: holidays/locale/en_US/LC_MESSAGES/CF.po:13-28
Timestamp: 2025-06-29T09:37:35.283Z
Learning: In the holidays project, .po files follow a standard formatting convention where there is always a blank line after the metadata header section (after the "X-Source-Language" line). This blank line separates the header from the actual translation content and should not be removed.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
📚 Learning: 2025-06-25T10:09:29.029Z
Learnt from: PPsyrius
PR: vacanza/holidays#2676
File: holidays/locale/ar/LC_MESSAGES/EG.po:0-0
Timestamp: 2025-06-25T10:09:29.029Z
Learning: In the holidays library, msgstr fields can be left empty for source/default_language files when using Lingva, the localization tool used by the project.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-06-10T12:17:58.880Z
Learnt from: KJhellico
PR: vacanza/holidays#2608
File: holidays/locale/en_VC/LC_MESSAGES/VC.po:1-14
Timestamp: 2025-06-10T12:17:58.880Z
Learning: In the holidays project, .po files should use the full multi-line header format including the project description, authors, website, and license information, rather than a single-line comment format.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-04-17T17:08:48.082Z
Learnt from: PPsyrius
PR: vacanza/holidays#2438
File: holidays/locale/ar_IQ/LC_MESSAGES/IQ.po:35-81
Timestamp: 2025-04-17T17:08:48.082Z
Learning: In holiday PO files, when the file represents the default language of an entity (e.g., ar_IQ for Iraq), no translations in `msgstr` are required as the `msgid` values are already in the target language.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-03-08T11:28:48.652Z
Learnt from: KJhellico
PR: vacanza/holidays#2259
File: holidays/locale/en_IN/LC_MESSAGES/IN.po:285-299
Timestamp: 2025-03-08T11:28:48.652Z
Learning: In the holidays project, message IDs (msgids) in locale files use region-specific naming conventions (e.g., "Muharram", "Id-ul-Fitr" in en_IN locale for India), while translator comments use internationally recognized names from the project's default locale (en_US) such as "Ashura", "Eid al-Fitr". This difference is intentional for proper localization.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
📚 Learning: 2025-03-30T13:33:31.598Z
Learnt from: PPsyrius
PR: vacanza/holidays#2388
File: holidays/locale/fr/LC_MESSAGES/CI.po:28-101
Timestamp: 2025-03-30T13:33:31.598Z
Learning: In the holidays library, for localization files of the default language (like French for Ivory Coast in fr/LC_MESSAGES/CI.po), the best practice is to leave the message strings (msgstr) empty to avoid possible typos, since the message IDs (msgid) are already in the target language.

Applied to files:

  • holidays/locale/en_US/LC_MESSAGES/PH.po
  • holidays/locale/fil/LC_MESSAGES/PH.po
  • holidays/locale/en_PH/LC_MESSAGES/PH.po
  • holidays/locale/th/LC_MESSAGES/PH.po
📚 Learning: 2025-06-25T20:55:00.642Z
Learnt from: KJhellico
PR: vacanza/holidays#2651
File: holidays/locale/nl/LC_MESSAGES/BQ.po:29-95
Timestamp: 2025-06-25T20:55:00.642Z
Learning: In the holidays library, Dutch locale files (.po) with `X-Source-Language: nl` should have empty msgstr entries when the target language is also Dutch. The library uses fallback=True with gettext, which returns the original msgid when msgstr is empty. This is the correct pattern for native language files and does not cause blank holiday names.

Applied to files:

  • holidays/locale/fil/LC_MESSAGES/PH.po
📚 Learning: 2025-04-13T19:11:32.337Z
Learnt from: KJhellico
PR: vacanza/holidays#2465
File: holidays/locale/nl/LC_MESSAGES/SR.po:31-32
Timestamp: 2025-04-13T19:11:32.337Z
Learning: In the holidays library, when a language is set as the default language for a country (like Dutch/nl for Suriname), the `msgid` strings in the PO file are already in that language, and the corresponding `msgstr` fields are intentionally left empty. This is by design, as the system will fall back to using the `msgid` value when no translation is provided.

Applied to files:

  • holidays/locale/fil/LC_MESSAGES/PH.po
📚 Learning: 2025-04-03T05:59:57.480Z
Learnt from: PPsyrius
PR: vacanza/holidays#2407
File: snapshots/countries/TL_COMMON.json:7-7
Timestamp: 2025-04-03T05:59:57.480Z
Learning: In the holidays project, snapshot files (like snapshots/countries/TL_COMMON.json) are auto-generated when running `make snapshot` and should not be manually edited. Semicolons (;) in holiday entries are used as separators when multiple holidays occur on the same date.

Applied to files:

  • snapshots/countries/PH_COMMON.json
📚 Learning: 2025-06-24T17:26:17.728Z
Learnt from: KJhellico
PR: vacanza/holidays#2654
File: snapshots/countries/CV_RS.json:471-478
Timestamp: 2025-06-24T17:26:17.728Z
Learning: Snapshot files in the holidays library (like those in snapshots/countries/) are generated automatically and should not be manually edited. Any issues with snapshot content should be addressed in the source code that generates them, not in the snapshot files themselves.

Applied to files:

  • snapshots/countries/PH_COMMON.json
📚 Learning: 2025-06-26T13:20:10.172Z
Learnt from: PPsyrius
PR: vacanza/holidays#2678
File: holidays/locale/th/LC_MESSAGES/US.po:30-34
Timestamp: 2025-06-26T13:20:10.172Z
Learning: In the holidays library Thai localizations, the "observed" format consistently uses "ชดเชย%s" without spaces between the Thai word and placeholder across all .po files in the codebase.

Applied to files:

  • holidays/locale/th/LC_MESSAGES/PH.po
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build distribution
  • GitHub Check: Test docs build
🔇 Additional comments (11)
snapshots/countries/PH_COMMON.json (1)

623-627: 2026 All Souls’ Day and Christmas Eve entries align with Proclamation 1006.

The additions for 2026-11-02 (“All Souls' Day”) and 2026-12-24 (“Christmas Eve”) match the government list for 2026 holidays. Looks good. (pna.gov.ph)

holidays/locale/fil/LC_MESSAGES/PH.po (2)

17-21: Metadata bump is fine.

Header updates are consistent with project norms.


123-126: New translations read well and match usage.

“Bisperas ng Pasko” and “Araw ng mga Kaluluwa” are correct and consistent with prior style. No further action.

Also applies to: 131-134

holidays/locale/th/LC_MESSAGES/PH.po (2)

17-21: Metadata bump is fine.


123-126: Thai additions look correct.

“วันคริสต์มาสอีฟ” and “วันภาวนาอุทิศแด่ผู้ล่วงลับ” are appropriate; consistent with other TH files.

Also applies to: 131-134

holidays/locale/en_US/LC_MESSAGES/PH.po (2)

17-21: Metadata bump is fine.


123-126: Added entries OK.

Explicit blocks for “Christmas Eve” and “All Souls’ Day” align with new PH data.

Also applies to: 131-134

holidays/locale/en_PH/LC_MESSAGES/PH.po (2)

17-21: Metadata bump is fine.


123-126: Keys added correctly.

Empty msgstr is expected for the default locale; entries will fall back to msgid.

Also applies to: 131-133

holidays/countries/philippines.py (1)

248-250: Good call centralizing “Christmas Eve.”

This avoids duplicate tr()s and keeps l10n tidy.

tests/countries/test_philippines.py (1)

100-101: 2026 CNY date addition LGTM.

Date matches the proclamation’s additional special (non-working) day list. (pna.gov.ph)

Copy link

Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇵🇭

@arkid15r arkid15r added this pull request to the merge queue Sep 10, 2025
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into vacanza:dev with commit d1e4d1c Sep 10, 2025
36 checks passed
@KJhellico KJhellico deleted the upd-philippines branch September 10, 2025 19:08
@KJhellico KJhellico mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载