-
-
Notifications
You must be signed in to change notification settings - Fork 541
Update Philippines holidays: 2025 Eid'l Adha Proclamation URL #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughReference URLs in the Philippines holiday class docstring were updated to archive.org links, tentative dates for 2025 Eid holidays were removed, and a new proclamation reference was added. No functional code or exported entities were changed. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)holidays/countries/philippines.py (1)
🪛 Pylint (3.3.7)holidays/countries/philippines.py[convention] 52-52: Line too long (103/100) (C0301) [convention] 55-55: Line too long (102/100) (C0301) 🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
holidays/countries/philippines.py
(1 hunks)
🧰 Additional context used
🪛 Pylint (3.3.7)
holidays/countries/philippines.py
[convention] 56-56: Line too long (112/100)
(C0301)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇵🇭
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2600 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 225 227 +2
Lines 14362 14470 +108
Branches 2017 2027 +10
==========================================
+ Hits 14362 14470 +108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the source archival helps 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kleo thanks for keeping this consistent 👍
Proposed change
Adding recent proclamation url for Eid'l Adha.
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green