+
Skip to content

Update Philippines holidays: 2025 Eid'l Adha Proclamation URL #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2025

Conversation

kleo
Copy link
Contributor

@kleo kleo commented Jun 5, 2025

Proposed change

Adding recent proclamation url for Eid'l Adha.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link
Contributor

coderabbitai bot commented Jun 5, 2025

Summary by CodeRabbit

  • Documentation
    • Updated reference URLs in the Philippines holiday documentation to use archive.org links.
    • Added a new reference for "Proclamation No. 911/2025" and removed a tentative date reference for 2025 Eid'l Fitr and Eid'l Adha.

Summary by CodeRabbit

  • Documentation
    • Updated reference URLs in the Philippines holiday class docstring, replacing official government links with archive.org URLs.
    • Removed tentative date references for 2025 Eid'l Fitr and Eid'l Adha.
    • Added a new reference link for "Proclamation No. 911/2025".

Walkthrough

Reference URLs in the Philippines holiday class docstring were updated to archive.org links, tentative dates for 2025 Eid holidays were removed, and a new proclamation reference was added. No functional code or exported entities were changed.

Changes

Files Change Summary
holidays/countries/philippines.py Updated and added archive.org reference links in docstring; removed tentative holiday date references.

Possibly related PRs

Suggested reviewers

  • KJhellico

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fab237c and 05dc85c.

📒 Files selected for processing (1)
  • holidays/countries/philippines.py (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
holidays/countries/philippines.py (1)
Learnt from: PPsyrius
PR: vacanza/holidays#2600
File: holidays/countries/philippines.py:56-56
Timestamp: 2025-06-05T18:24:26.667Z
Learning: In the holidays repository, if code passes `make pre-commit` checks, then it's allowed regardless of individual static analysis tool warnings like Pylint line length violations. The pre-commit hooks are the definitive source of truth for their coding standards.
🪛 Pylint (3.3.7)
holidays/countries/philippines.py

[convention] 52-52: Line too long (103/100)

(C0301)


[convention] 55-55: Line too long (102/100)

(C0301)

🔇 Additional comments (2)
holidays/countries/philippines.py (2)

50-51: Approve archived URLs for 2024 proclamations. The archive.org links for Proclamation Nos. 665/2024 and 729/2024 are correctly added, ensuring stable references.


53-55: Approve added proclamations for 2025 Eid'l Adha. Entries for Proclamation Nos. 839/2025, 878/2025, and 911/2025 are accurately listed in chronological order.

🧰 Tools
🪛 Pylint (3.3.7)

[convention] 55-55: Line too long (102/100)

(C0301)

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32a0f7c and fab237c.

📒 Files selected for processing (1)
  • holidays/countries/philippines.py (1 hunks)
🧰 Additional context used
🪛 Pylint (3.3.7)
holidays/countries/philippines.py

[convention] 56-56: Line too long (112/100)

(C0301)

PPsyrius
PPsyrius previously approved these changes Jun 5, 2025
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇵🇭

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ae8c67f) to head (05dc85c).
Report is 15 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##               dev     #2600    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          225       227     +2     
  Lines        14362     14470   +108     
  Branches      2017      2027    +10     
==========================================
+ Hits         14362     14470   +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Jun 6, 2025

Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the source archival helps 👍

@arkid15r arkid15r changed the title Update Philippines holidays: 2025 Eid'l Adha Proclamation url Update Philippines holidays: 2025 Eid'l Adha Proclamation URL Jun 7, 2025
@arkid15r arkid15r enabled auto-merge June 7, 2025 01:47
@arkid15r arkid15r added this pull request to the merge queue Jun 7, 2025
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kleo thanks for keeping this consistent 👍

Merged via the queue into vacanza:dev with commit 2215a5d Jun 7, 2025
33 checks passed
@arkid15r arkid15r mentioned this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载