-
-
Notifications
You must be signed in to change notification settings - Fork 558
Add Cabo Verde holidays #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cabo Verde holidays #2654
Conversation
# Conflicts: # README.md # holidays/countries/__init__.py
…hanges from the dev branch and resolved conflicts by accepting the new branch changes.
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughCabo Verde (Cape Verde) holiday support was added to the codebase. This includes a new country module, registration, translations in five languages, subdivision support, documentation updates, and comprehensive holiday date snapshots for all regions and municipalities from 1976 to 2050. Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
♻️ Duplicate comments (2)
holidays/locale/es/LC_MESSAGES/CV.po (1)
73-75
: Use “Día de Navidad” for naming consistency (comment repeated).
Most holiday translations begin with “Día …”, so keeping the same pattern here would read better.holidays/locale/fr/LC_MESSAGES/CV.po (1)
61-64
: Duplicate: trim “Fête de” to stay inline with French style guide
Same remark as in the earlier review: the project omits the leading “Fête de”.-msgstr "Fête de l'Indépendance Nationale" +msgstr "Jour de l'Indépendance"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Prateekshit Jaiswal <67361301+Prateekshit73@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for completing this @Prateekshit73!
Proposed change
Add Cabo Verde holidays.
Resolves #1159.
Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green