+
Skip to content

Conversation

Prateekshit73
Copy link
Contributor

Proposed change

Add Cabo Verde holidays.
Resolves #1159.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link
Contributor

coderabbitai bot commented Jun 21, 2025

Summary by CodeRabbit

  • New Features

    • Added support for Cape Verde (Cabo Verde) public holidays, including national and municipal holidays, from 1976 to 2050.
    • Introduced Cape Verde holiday data snapshots for all regions and municipalities.
    • Added localizations for Cape Verde holidays in German, US English, Spanish, French, and Cape Verdean Portuguese.
    • Updated documentation to reflect support for Cape Verde and increased the supported country count.
  • Chores

    • Added a new contributor to the CONTRIBUTORS list.

Summary by CodeRabbit

  • New Features

    • Added support for Cabo Verde (CV) holidays, including national and municipal observances from 1976 to 2050.
    • Introduced Cabo Verde-specific holiday data and calendar snapshots.
    • Provided translations for Cabo Verde holidays in German, US English, Spanish, French, and Portuguese (pt_CV).
  • Documentation

    • Updated documentation to reflect Cabo Verde as a supported country and detailed its holidays, subdivisions, and available languages.
  • Chores

    • Added a new contributor to the contributors list.

Walkthrough

Cabo Verde (Cape Verde) holiday support was added to the codebase. This includes a new country module, registration, translations in five languages, subdivision support, documentation updates, and comprehensive holiday date snapshots for all regions and municipalities from 1976 to 2050.

Changes

Files/Groups Change Summary
holidays/countries/cabo_verde.py New module implementing Cabo Verde holidays, subdivisions, aliases, and logic.
holidays/countries/init.py, holidays/registry.py Registered Cabo Verde in country imports and registry.
holidays/locale/de/LC_MESSAGES/CV.po, holidays/locale/en_US/LC_MESSAGES/CV.po, Added German, English, Spanish, French, and Portuguese (pt_CV) translations for Cabo Verde holidays.
holidays/locale/es/LC_MESSAGES/CV.po, holidays/locale/fr/LC_MESSAGES/CV.po,
holidays/locale/pt_CV/LC_MESSAGES/CV.po
README.md Updated to document Cabo Verde support, subdivisions, languages, and categories.
snapshots/countries/CV_*.json Added holiday date snapshots for all Cabo Verde regions/municipalities (1976–2050).
CONTRIBUTORS Added "Sindhura Kumbakonam Subramanian" to the contributors list.

Possibly related PRs

Suggested reviewers

  • arkid15r
  • PPsyrius
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

♻️ Duplicate comments (2)
holidays/locale/es/LC_MESSAGES/CV.po (1)

73-75: Use “Día de Navidad” for naming consistency (comment repeated).
Most holiday translations begin with “Día …”, so keeping the same pattern here would read better.

holidays/locale/fr/LC_MESSAGES/CV.po (1)

61-64: Duplicate: trim “Fête de” to stay inline with French style guide
Same remark as in the earlier review: the project omits the leading “Fête de”.

-msgstr "Fête de l'Indépendance Nationale"
+msgstr "Jour de l'Indépendance"

KJhellico
KJhellico previously approved these changes Jul 20, 2025
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Prateekshit Jaiswal <67361301+Prateekshit73@users.noreply.github.com>
Copy link

@arkid15r arkid15r enabled auto-merge July 21, 2025 00:40
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for completing this @Prateekshit73!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Cabo Verde holidays

6 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载