+
Skip to content

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Set Python 3.13 as primary in CI/CD.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link
Contributor

coderabbitai bot commented Jun 6, 2025

Summary by CodeRabbit

  • Chores
    • Updated the Python version used in CI/CD workflows, documentation builds, and testing environments from 3.12 to 3.13.

Summary by CodeRabbit

  • Chores
    • Updated the Python version to 3.13 in continuous integration workflows and documentation builds.

Walkthrough

The Python version specified in various CI/CD workflows, the Read the Docs configuration, and the tox test environment was updated from 3.12 to 3.13. No other workflow logic, steps, or configuration settings were changed.

Changes

Files/Groups Change Summary
.github/workflows/ci-cd.yml Updated Python version in the build job from 3.12 to 3.13
.github/workflows/pre-commit-autoupdate.yml Updated Python version in setup-python from 3.12 to 3.13
.github/workflows/update-snapshots.yml Updated Python version in setup step from 3.12 to 3.13
.readthedocs.yaml, tox.ini Updated Python version from 3.12 to 3.13 in docs build and tox environment

Possibly related PRs

Suggested labels

test


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fb0786 and dc6e444.

📒 Files selected for processing (1)
  • tox.ini (1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (1)
  • GitHub Check: Run pre-commit
🔇 Additional comments (1)
tox.ini (1)

18-18: Docs environment set to Python 3.13
Base Python now points to python3.13 in the docs env, which matches the updated CI workflows and the env_list ordering.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci label Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7618b69) to head (dc6e444).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2605   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines        14470     14470           
  Branches      2027      2027           
=========================================
  Hits         14470     14470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PPsyrius
PPsyrius previously approved these changes Jun 6, 2025
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛠️

arkid15r
arkid15r previously approved these changes Jun 6, 2025
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KJhellico KJhellico dismissed stale reviews from arkid15r and PPsyrius via dc6e444 June 6, 2025 15:41
Copy link

sonarqubecloud bot commented Jun 6, 2025

@arkid15r arkid15r added this pull request to the merge queue Jun 6, 2025
Merged via the queue into vacanza:dev with commit 2421357 Jun 6, 2025
33 checks passed
@KJhellico KJhellico deleted the upd-313 branch June 7, 2025 13:39
@arkid15r arkid15r mentioned this pull request Jun 16, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jun 19, 2025
9 tasks
@coderabbitai coderabbitai bot mentioned this pull request Oct 9, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载