Update Python latest supported version format #2466

arkid15r · 2025-04-13T21:14:32Z

Proposed change

Update Python latest supported version format

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-04-13T21:14:38Z

Summary by CodeRabbit

Chores
- Improved the consistency of internal Python version information by updating the format to reflect the latest supported version.

Walkthrough

The update modifies the handling of version information in the tests/common.py file. Two constants that previously used tuple formats now use string representations. Specifically, the latest supported Python version is updated from (3, 12) to "3.13", and the current Python version is now generated using an f-string instead of a tuple.

Changes

File	Change Summary
tests/common.py	Updated `PYTHON_LATEST_SUPPORTED_VERSION` from `(3, 12)` to `"3.13"`; changed `PYTHON_VERSION` from a tuple `(sys.version_info.major, sys.version_info.minor)` to a formatted string `f"{sys.version_info.major}.{sys.version_info.minor}"`

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1448815 and e8271fb.

📒 Files selected for processing (1)

tests/common.py (1 hunks)

⏰ Context from checks skipped due to timeout of 300000ms (3)

GitHub Check: Test build on ubuntu-latest
GitHub Check: Test build on windows-latest
GitHub Check: Test build on macos-latest

🔇 Additional comments (1)

tests/common.py (1)

24-25:
✅ Verification successful

Approve format change from tuple to string for Python version constants

The change from tuple representation to string format for both constants is good - it makes the version more human-readable and aligns with common version representation formats. The update also introduces support for Python 3.13.

One consideration: ensure that any code comparing these constants has been updated to handle string comparisons rather than tuple comparisons. String version comparisons can behave differently than tuple comparisons (e.g., "3.2" > "3.10" lexicographically, while (3, 2) < (3, 10) numerically).

🏁 Script executed:
#!/bin/bash
# Check for any usage of these constants that might rely on tuple behavior
echo "Looking for usage of PYTHON_LATEST_SUPPORTED_VERSION and PYTHON_VERSION..."
rg "PYTHON_(LATEST_SUPPORTED_VERSION|VERSION)" --type py -A 3 -B 3
Length of output: 2722
Approved constant format change with caution on order comparisons

The conversion from tuple to string for Python version constants in tests/common.py is good. We've checked the repository usage, and currently, the only comparisons (using !=) in both tests/test_utils.py and tests/test_registry.py properly compare the strings. Just be mindful that if future comparisons rely on order (using < or >) rather than equality, you may need to adjust those comparisons to account for lexicographical order differences.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-04-13T21:16:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (da10db4) to head (8a0bee2).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2466   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          210       210           
  Lines        13352     13352           
  Branches      1911      1911           
=========================================
  Hits         13352     13352

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KJhellico

LGTM.

PPsyrius

LGTM

sonarqubecloud · 2025-04-13T23:10:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Update Python latest supported version format

e8271fb

arkid15r requested review from KJhellico and PPsyrius as code owners April 13, 2025 21:14

github-actions bot added the test label Apr 13, 2025

arkid15r enabled auto-merge April 13, 2025 21:14

KJhellico previously approved these changes Apr 13, 2025

View reviewed changes

PPsyrius previously approved these changes Apr 13, 2025

View reviewed changes

Merge branch 'dev' into update-common-tests

8a0bee2

arkid15r dismissed stale reviews from PPsyrius and KJhellico via 8a0bee2 April 13, 2025 23:09

arkid15r requested review from KJhellico and PPsyrius April 13, 2025 23:11

PPsyrius approved these changes Apr 13, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Apr 13, 2025

Merged via the queue into vacanza:dev with commit b4d60d5 Apr 13, 2025
33 checks passed

arkid15r deleted the update-common-tests branch April 13, 2025 23:28

KJhellico mentioned this pull request Apr 21, 2025

v0.71 #2485

Merged

coderabbitai bot mentioned this pull request Jun 6, 2025

Set Python 3.13 as primary in CI/CD #2605

Merged

9 tasks

coderabbitai bot mentioned this pull request Oct 9, 2025

Switch to Python 3.14 #2997

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update Python latest supported version format #2466

Update Python latest supported version format #2466

Uh oh!

arkid15r commented Apr 13, 2025

Uh oh!

coderabbitai bot commented Apr 13, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented Apr 13, 2025 •

edited

Loading

Uh oh!

KJhellico left a comment

Uh oh!

PPsyrius left a comment

Uh oh!

sonarqubecloud bot commented Apr 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Update Python latest supported version format #2466

Update Python latest supported version format #2466

Uh oh!

Conversation

arkid15r commented Apr 13, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

codecov bot commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

PPsyrius left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 13, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Apr 13, 2025 •

edited

Loading

codecov bot commented Apr 13, 2025 •

edited

Loading