Add Åland Islands holidays. Update Finland holidays #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: Panpakorn Siripanich <19505219+PPsyrius@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
…_language fallback
Aland PR suggestions
Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Signed-off-by: Ary Hauffe <41094281+Arynelson@users.noreply.github.com>
arkid15r
approved these changes
May 28, 2025
There was a problem hiding this comment.
Thank you @Arynelson and @PPsyrius ! It's ready to be merged now.
|
Merged
3 tasks
9 tasks
9 tasks
This was referenced Jun 26, 2025
Merged
9 tasks
This was referenced Jul 21, 2025
Merged
Merged
This was referenced Jul 29, 2025
Merged
This was referenced Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
en_US,fi,sv_FI,th,uk; categories:PUBLIC,UNOFFICIAL,WORKDAY), also available as part of Finland holidays as subdivision01.thl10n.WORKDAY) and Customary (UNOFFICIAL) Flag Days into separate categories for both Finland and Åland Islands.I've set up Git venv properly on my backup laptop this time, so all of my personal commits should now be verified. 🙏
Resolves #2424 .
Supercedes #2449 .
Note
As per discussed below, the edit to
HolidayBase.pyto allow Åland Islands to havesv_FIas its default_language instead offilike its parent entity, Finland - will be done in a separate future PR.Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green