Reviewing files that changed from the base of the PR and between 180b104 and 3595f4a.

• README.md (2 hunks)
• holidays/countries/togo.py (1 hunks)
• holidays/locale/fr/LC_MESSAGES/TG.po (1 hunks)
• holidays/registry.py (1 hunks)
• tests/countries/test_togo.py (1 hunks)

holidays/registry.py (1)

175-175: Togo entry successfully added

The Togo entry is correctly positioned alphabetically in the COUNTRIES registry with proper ISO codes.

README.md (2)

108-108: Total country count updated correctly

The number of supported countries is correctly incremented from 171 to 172 to reflect Togo's addition.

---

1215-1220: Togo documentation entry correctly added

The Togo entry is properly added to the countries table with appropriate ISO code, language support, and holiday category information.

holidays/locale/fr/LC_MESSAGES/TG.po (1)

1-94: French translations for Togo properly implemented

This new translation file correctly provides French holiday names for Togo. Since French is the default language for Togo, the message strings (msgstr) are appropriately left empty as no translation is needed from the message IDs that are already in French.

The file includes all necessary holiday name definitions, including fixed date holidays, Christian observances, Islamic holidays, and format strings for estimated and observed holidays.

tests/countries/test_togo.py (6)

13-27: Test setup is comprehensive

The test class is properly set up with appropriate imports, year ranges (1960-2050), and test variations including holidays with and without estimated labels and optional holidays.

---

28-34: Country aliases and pre-independence tests are correct

Tests appropriately verify:

1. The country aliases (TG, TGO) for Togo
2. No holidays exist before independence (1959)

This ensures proper historical accuracy and code organization.

---

35-112: Fixed and Christian holidays tests are thorough

The tests comprehensively cover:

1. Fixed date holidays (New Year's Day, Independence Day, Labor Day, etc.)
2. Christian movable holidays (Good Friday, Easter Monday, Ascension, etc.)
3. Historical holidays (Liberation Day from 1967-2013)

All date calculations and ranges are accurate.

---

113-176: Islamic holidays tests include known dates

The tests for Islamic holidays (Ramadan, Eid al-Fitr, and Eid al-Adha) include concrete test cases with known dates for multiple years, ensuring the lunar calendar calculations are accurate. Tests also verify behavior with and without estimated labels.

---

177-202: Optional holidays tests are properly implemented

Tests for optional holidays like Mawlid and the Anniversary of the Failed Attack on Lomé correctly:

1. Filter by the OPTIONAL category
2. Include known dates for verification
3. Check historical boundaries (post-1987 for the Anniversary)

---

203-240: Comprehensive year tests validate holiday combinations

The full year tests for 2024 and 2025 verify that all holidays appear correctly together, ensuring the overall holiday set is accurate and complete for these sample years.

holidays/countries/togo.py (2)

148-208: Limited date range for Islamic holidays

The Islamic holiday dates are only defined up to 2025. Consider adding a comment indicating when these dates should be reviewed and updated to ensure long-term maintenance.

class TogoIslamicHolidays(_CustomIslamicHolidays):
+    # These dates should be reviewed and extended beyond 2025 before that year

---

1-209: Solid implementation of Togo holiday calendar

The implementation follows the library patterns well, with comprehensive documentation, proper references for holiday sources, and good organization of public and optional holidays. The date handling is thorough, especially for Islamic holidays which follow a lunar calendar.

Reviewing files that changed from the base of the PR and between 3595f4a and 55b077c.

• README.md (2 hunks)
• holidays/countries/togo.py (1 hunks)
• holidays/locale/fr/LC_MESSAGES/TG.po (1 hunks)

README.md (2)

108-108: Update supported country count
The total country count was correctly incremented from 171 to 172 to account for Togo.

---

1215-1220: Togo entry matches implementation
The new table row for Togo (TG) with French language support and OPTIONAL category aligns with the Togo class (default_language="fr" and supported_categories includes OPTIONAL).

holidays/locale/fr/LC_MESSAGES/TG.po (2)

1-15: Header metadata looks good
The file header correctly identifies the project, authors, and license.

---

16-98: Populate msgstr for French translations
The .po file currently contains empty msgstr "" for all entries. To make the French locale functional, each msgstr should either mirror the msgid (for untranslated defaults) or provide the proper French translation. Consider running msgmerge or copying the msgid into msgstr as a first pass.

holidays/countries/togo.py (5)

13-23: Imports are correct and complete
Required modules (gettext, calendar constants, holiday groups, and base classes) are appropriately imported.

---

84-130: Holiday additions look sound
Public holidays (fixed and movable) are correctly added with translation wrappers and accurate year conditions (e.g., Liberation Day only 1967–2013).

---

131-138: Optional holiday logic is correct
Mawlid is always included and the failed-attack anniversary starts in 1987. Conditions and method calls match requirements.

---

140-146: Aliases for TG and TGO are in place
Providing both TG and TGO aliases aligns with ISO code conventions.

---

148-209: Custom Islamic dates mapping is thorough
Explicit date mappings for Eid al-Adha, Eid al-Fitr, Mawlid, and Ramadan covering 2010–2025 are provided. Consider verifying that fallback lunar calculations align correctly for years prior to the first mapped entry.

Reviewing files that changed from the base of the PR and between 55b077c and 2e5004e.

• holidays/countries/togo.py (1 hunks)
• holidays/locale/fr/LC_MESSAGES/TG.po (1 hunks)

holidays/locale/fr/LC_MESSAGES/TG.po (1)

13-14: French locale header is correctly set up
French is the default language, so having msgid entries in French with empty msgstr is appropriate.

holidays/countries/togo.py (1)

84-87: Verify Liberation Day date range boundaries
The condition if 1967 <= year < 2014 excludes 2014. Confirm whether Liberation Day should be observed in 2014 or end in 2013.

Do your tests cover the year 2014 case? If the holiday runs through 2014, consider changing to self._year <= 2014.

Reviewing files that changed from the base of the PR and between 2e5004e and 5d8d2a2.

• holidays/countries/togo.py (1 hunks)
• holidays/locale/fr/LC_MESSAGES/TG.po (1 hunks)
• tests/countries/test_togo.py (1 hunks)

holidays/locale/fr/LC_MESSAGES/TG.po (3)

1-87: The TG.po file looks good overall

The French translations for Togo holidays are well-structured and correctly implemented. The message strings are empty as expected since French is the default language (no translation needed). Well done on providing comprehensive holiday coverage.

---

86-87: 🧹 Nitpick (assertive)

Normalize apostrophe style in "Anniversaire de l'attentat manqué contre Lomé"

Replace the curly apostrophe with a straight one for consistency.

-msgid "Anniversaire de l'attentat manqué contre Lomé"
+msgid "Anniversaire de l'attentat manqué contre Lomé"

Likely an incorrect or invalid review comment.

---

46-47: 🧹 Nitpick (assertive)

Normalize apostrophe style in "Fête de l'Ascension"

Replace the curly apostrophe with a straight one for consistency.

-msgid "Fête de l'Ascension"
+msgid "Fête de l'Ascension"

Likely an incorrect or invalid review comment.

tests/countries/test_togo.py (1)

1-240: Great test coverage for Togo holidays

The test suite is comprehensive and thoroughly tests all aspects of the Togo holiday implementation:

• Tests for fixed holidays, movable holidays, and optional holidays
• Verification of historically bounded holidays (Liberation Day)
• Specific date assertions for Islamic holidays
• Tests with and without estimated dates
• Country alias tests
• Tests for pre-independence period

This is a solid, well-structured test suite that ensures the correctness of the implementation.

holidays/countries/togo.py (4)

26-55: Excellent documentation and references

The class documentation is thorough and includes numerous references to validate the holiday implementations. This is exemplary practice for country holiday implementations, making it easy to verify and update the code in the future.

---

144-204: Well-structured Islamic holiday dates implementation

The TogoIslamicHolidays class is well-structured with explicit date mappings for Islamic holidays from 2010-2025. This approach ensures accuracy for known dates while falling back to calculated dates when necessary.

---

1-205: Overall excellent implementation of Togo holidays

The implementation is comprehensive, well-documented, and follows the library's patterns and best practices. The class hierarchy, initialization, and holiday population methods are structured correctly. The code includes both fixed and movable holidays, with proper handling of historically bounded holidays.

---

101-101: 🧹 Nitpick (assertive)

Normalize apostrophe style in "Fête de l'Ascension"

Replace the curly apostrophe with a straight one for consistency.

-        self._add_ascension_thursday(tr("Fête de l'Ascension"))
+        self._add_ascension_thursday(tr("Fête de l'Ascension"))

Likely an incorrect or invalid review comment.

Reviewing files that changed from the base of the PR and between 5d8d2a2 and b5efd6c.

• tests/countries/test_togo.py (1 hunks)

tests/countries/test_togo.py (7)

20-26: Great test class setup for Togo holidays

The setup properly initializes test data from 1960 (Togo's independence) through 2050, which provides comprehensive test coverage. The class also creates specialized test instances for non-estimated holidays and optional holidays.

---

31-33: Good pre-independence check

The test correctly verifies that no holidays existed before Togo's independence in 1960, which is historically accurate.

---

38-41: Excellent historical boundary check

The test correctly handles the Liberation Day holiday that was observed from 1967 to 2013 and confirms it's not observed after 2013, respecting the historical constraints.

---

125-141: Thorough Islamic holiday testing

The tests for Ramadan, Eid al-Fitr, and Eid al-Adha properly check specific dates for multiple years and also verify correct behavior with the islamic_show_estimated=False parameter. This comprehensive approach ensures the Islamic lunar calendar dates are correctly mapped.

Also applies to: 143-164, 166-187

---

209-214: Good implementation of optional holiday tests

The optional holiday tests correctly verify that Mawlid Day and the Anniversary of the Failed Attack on Lomé are categorized as optional holidays, and the latter properly respects its historical starting point in 1987.

Also applies to: 202-207

---

216-252: 🧹 Nitpick (assertive)

Consider adding more yearly test cases

While you've included comprehensive tests for 2024 and 2025, adding test cases for additional years (perhaps historically significant years for Togo or years with unusual holiday patterns) would provide even more robust coverage.

Consider adding similar yearly test cases for years like 1960 (independence year), 1987 (when the anniversary of the failed attack was introduced), or other significant dates in Togo's history.

⛔ Skipped due to learnings

Learnt from: PPsyrius
PR: vacanza/holidays#2386
File: tests/countries/test_nepal.py:499-536
Timestamp: 2025-04-05T06:49:06.217Z
Learning: In the holidays project, test files follow a dual testing approach: individual methods test specific holidays across multiple years, while comprehensive year-specific tests (e.g., `test_2025`) verify all holidays for a specific year in a single assertion. Both approaches serve different testing purposes and complement each other.

Learnt from: PPsyrius
PR: vacanza/holidays#2416
File: tests/countries/test_turkmenistan.py:52-64
Timestamp: 2025-04-05T04:47:27.213Z
Learning: For holiday tests in the vacanza/holidays project, structure tests by individual holidays rather than by years. Each test method should focus on a specific holiday and test it across multiple years (from start_year through 2050) using helper methods like `assertHolidayName`. For fixed holidays, use generators like `(f"{year}-01-01" for year in range(1991, 2051))`. For movable holidays, specify individual dates for specific years followed by a range check.

---

96-111: 🧹 Nitpick (assertive)

Inconsistency between specific dates and range check in Whit Monday test

The test specifies particular dates for years 1960, 1970-1972, and 2020-2025, but the range check on line 111 covers all years from 1960 to 1973, which means years 1961-1969 and 1973 are tested in the range but don't have specific date assertions.

Either adjust the range to match the specific dates:

-self.assertHolidayName(name, range(1960, 1973))
+self.assertHolidayName(name, range(1960, 1961))
+self.assertHolidayName(name, range(1970, 1973))

Or add more specific dates for the missing years to ensure complete coverage.

⛔ Skipped due to learnings

Learnt from: PPsyrius
PR: vacanza/holidays#2416
File: tests/countries/test_turkmenistan.py:52-64
Timestamp: 2025-04-05T04:47:27.213Z
Learning: For holiday tests in the vacanza/holidays project, structure tests by individual holidays rather than by years. Each test method should focus on a specific holiday and test it across multiple years (from start_year through 2050) using helper methods like `assertHolidayName`. For fixed holidays, use generators like `(f"{year}-01-01" for year in range(1991, 2051))`. For movable holidays, specify individual dates for specific years followed by a range check.

Reviewing files that changed from the base of the PR and between 4944892 and 2c888bf.

• holidays/countries/togo.py (1 hunks)
• tests/countries/test_togo.py (1 hunks)

holidays/countries/togo.py (3)

26-62: Good implementation of Togo holidays with thorough documentation.

The class is well-structured with excellent documentation, including extensive references for holiday date verification. The implementation correctly sets up Togo's country attributes including:

• ISO code "TG"
• French as default language
• Proper supported categories (OPTIONAL, PUBLIC)
• Independence year as start_year (1960)

---

142-202: Well-implemented custom Islamic holiday dates.

The TogoIslamicHolidays class correctly provides specific date mappings for Islamic holidays in Togo from 2010-2025, ensuring accurate representation of:

• Eid al-Adha (Tabaski)
• Eid al-Fitr
• Mawlid
• Ramadan beginning

This approach of using verified local dates rather than pure calculation is excellent for accuracy.

---

78-132: Holiday implementation is complete and well-structured.

The holiday population methods:

• Correctly implement all Togo public and optional holidays
• Use appropriate date calculation methods
• Include date-conditional logic (Liberation Day: 1967-2013, Failed Attack Anniversary: 1987+)
• Consistently use translation functions for internationalization

The code organization is clean and readable, following a logical progression through the calendar.

Reviewing files that changed from the base of the PR and between b423fea and 9e18c68.

• README.md (2 hunks)
• holidays/countries/__init__.py (1 hunks)
• holidays/countries/togo.py (1 hunks)
• holidays/locale/en_US/LC_MESSAGES/TG.po (1 hunks)
• holidays/locale/fr/LC_MESSAGES/TG.po (1 hunks)
• tests/countries/test_togo.py (1 hunks)

holidays/countries/__init__.py (1)

167-167: Integrate Togo into the countries package

Adding from .togo import Togo, TG, TGO correctly registers the new Togo holiday calendar between TimorLeste and Tonga (alphabetical order).

README.md (2)

108-109: Update supported country count

The total supported countries count has been updated from 171 to 172 to reflect the addition of Togo.

---

1215-1220: Document Togo in the country table

The new table row for Togo (TG) with supported languages en_US and fr and category OPTIONAL aligns with other country entries.

holidays/locale/fr/LC_MESSAGES/TG.po (1)

1-101: French translation template added correctly

The French PO file for the Togo locale has been added with all message IDs. Ensure to populate msgstr entries as needed when finalizing translations.

holidays/locale/en_US/LC_MESSAGES/TG.po (1)

30-102: English translations for Togo holidays are accurate

All French message IDs are correctly mapped to their English equivalents in msgstr.

holidays/countries/togo.py (5)

13-19: Imports are well-organized

Standard library import (gettext.gettext) is separated from project-specific imports, and the necessary holiday mixins and constants are correctly brought in.

---

22-24: Class docstring present

The Togo class includes a concise docstring referencing authoritative sources. Good context for maintainers.

---

60-72: Constructor initializes mixins properly

The __init__ method correctly chains the Christian, International, and Islamic holiday initializers before calling super().

---

74-83: Public holiday definitions follow patterns

The _populate_public_holidays method uses mixin methods wrapped with tr(), ensuring translation consistency.

---

121-127: Optional holidays implemented correctly

The optional holidays, including Prophet Mohammed's Birthday and the anniversary of the failed attack (post-1987), are correctly scoped.

tests/countries/test_togo.py (1)

1-284: LGTM! Well-constructed test module for Togo holidays.

The test module is comprehensive and follows the project's testing conventions correctly. It includes:

• Tests for all public and optional holidays
• Proper verification of fixed and movable dates
• Chronologically ordered snapshots for 2024 and 2025
• Good coverage of Islamic holidays with exact dates
• Appropriate localization tests for both French and English

This is a solid implementation that meets all the requirements for holiday testing in the project.

Reviewing files that changed from the base of the PR and between e499330 and dc0811a.

• holidays/countries/togo.py (1 hunks)

holidays/countries/togo.py (1)

1-211: Well-structured implementation with comprehensive documentation.

The implementation follows library conventions with thorough documentation, references to sources, correct holiday definitions, and appropriate handling of subdivisions. The use of archived web links and detailed date mappings shows attention to detail.