+
Skip to content

Reformat .po files #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Reformat .po files #2356

merged 1 commit into from
Mar 19, 2025

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Reformat .po files (align with line length 99).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2025 •
edited
Loading

Summary by CodeRabbit

  • Style

    • Consolidated multiline translation entries into single-line strings across various holiday texts, ensuring enhanced readability and consistency in localized displays.

  • Chores

    • Standardized the text wrap width during localization file generation to maintain uniform formatting across all supported languages.

Walkthrough

The changes standardize the formatting of holiday translation files by consolidating multi‑line message identifiers and strings into single lines. This update affects a wide range of localization files for various languages (e.g., Arabic, Belarusian, Bulgarian, German, English, Thai, etc.) to improve readability and consistency. In addition, a new constant WRAP_WIDTH (set to 99) has been introduced in a Python script used for generating PO files, and related instantiations and function parameters have been updated accordingly.

Changes

File(s) Change Summary
holidays/locale/*/LC_MESSAGES/*.po Consolidated multi‑line msgid and msgstr entries into single-line entries across many localization files (e.g., for Arabic, Belarusian, Bulgarian, German, English—including multiple locales—Filipino, Khmer, Lithuanian, etc.). Several entries had missing translations filled in, or line breaks removed for improved clarity without altering semantic content.
scripts/l10n/generate_po_files.py Added a new constant WRAP_WIDTH with a value of 99. Updated the instantiation of the PO file object in update_po_file and modified the width parameter in process_entities to ensure a consistent wrap width during PO file generation.

Possibly related PRs

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a8acc78) to head (94b2ba9).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          204       204           
  Lines        12853     12853           
  Branches      1817      1817           
=========================================
  Hits         12853     12853

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PPsyrius
PPsyrius approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KJhellico Is there any other changes required or would make snapshot command automatically increase line limit to 99 now after this? 👀

Nvm, just saw WRAP_WIDTH, I somehow missed that during the first review somehow

@arkid15r
Copy link
Collaborator

LGTM

@KJhellico Is there any other changes required or would make snapshot command automatically increase line limit to 99 now after this? 👀

Nvm, just saw WRAP_WIDTH, I somehow missed that during the first review somehow

I believe no content change expected here, only code formatting changes.

arkid15r
arkid15r reviewed Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Mar 19, 2025
Merged via the queue into vacanza:dev with commit 556cd16 Mar 19, 2025
33 checks passed
@KJhellico KJhellico deleted the ref-po-files branch March 19, 2025 16:33
@PPsyrius PPsyrius mentioned this pull request Mar 24, 2025
Merged
9 tasks
@arkid15r arkid15r mentioned this pull request Apr 7, 2025
Merged
@coderabbitai coderabbitai bot mentioned this pull request Apr 10, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

Assignees
No one assigned
Labels
l10n script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KJhellico @arkid15r @PPsyrius
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载