Update .po files generator #2459
Conversation
Summary by CodeRabbit
These updates improve backend processes and system stability while preserving the end-user experience and display of holiday information. WalkthroughThis pull request standardizes comment formatting across multiple localization files by consolidating multi-line comments into single lines. The changes affect holiday description comments in various language-specific Changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 300000ms (1)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2459 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 210 210
Lines 13352 13352
Branches 1911 1911
=========================================
Hits 13352 13352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (49)
holidays/locale/be/LC_MESSAGES/BY.po(2 hunks)holidays/locale/de/LC_MESSAGES/DE.po(1 hunks)holidays/locale/en_HK/LC_MESSAGES/HK.po(1 hunks)holidays/locale/en_MO/LC_MESSAGES/MO.po(2 hunks)holidays/locale/en_TL/LC_MESSAGES/TL.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/AR.po(3 hunks)holidays/locale/en_US/LC_MESSAGES/BN.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/BY.po(2 hunks)holidays/locale/en_US/LC_MESSAGES/CN.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/DE.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/HK.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/KH.po(3 hunks)holidays/locale/en_US/LC_MESSAGES/LV.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/MD.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/MO.po(2 hunks)holidays/locale/en_US/LC_MESSAGES/RU.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/TH.po(1 hunks)holidays/locale/en_US/LC_MESSAGES/TL.po(1 hunks)holidays/locale/es/LC_MESSAGES/AR.po(3 hunks)holidays/locale/km/LC_MESSAGES/KH.po(3 hunks)holidays/locale/lv/LC_MESSAGES/LV.po(1 hunks)holidays/locale/ms/LC_MESSAGES/BN.po(1 hunks)holidays/locale/pt_MO/LC_MESSAGES/MO.po(2 hunks)holidays/locale/pt_TL/LC_MESSAGES/TL.po(1 hunks)holidays/locale/ro/LC_MESSAGES/MD.po(1 hunks)holidays/locale/ru/LC_MESSAGES/BY.po(2 hunks)holidays/locale/ru/LC_MESSAGES/RU.po(1 hunks)holidays/locale/tet/LC_MESSAGES/TL.po(1 hunks)holidays/locale/th/LC_MESSAGES/BN.po(1 hunks)holidays/locale/th/LC_MESSAGES/BY.po(2 hunks)holidays/locale/th/LC_MESSAGES/CN.po(1 hunks)holidays/locale/th/LC_MESSAGES/DE.po(1 hunks)holidays/locale/th/LC_MESSAGES/HK.po(1 hunks)holidays/locale/th/LC_MESSAGES/KH.po(3 hunks)holidays/locale/th/LC_MESSAGES/MO.po(2 hunks)holidays/locale/th/LC_MESSAGES/RU.po(1 hunks)holidays/locale/th/LC_MESSAGES/TH.po(1 hunks)holidays/locale/th/LC_MESSAGES/TL.po(1 hunks)holidays/locale/uk/LC_MESSAGES/AR.po(3 hunks)holidays/locale/uk/LC_MESSAGES/DE.po(1 hunks)holidays/locale/uk/LC_MESSAGES/LV.po(1 hunks)holidays/locale/uk/LC_MESSAGES/MD.po(1 hunks)holidays/locale/zh_CN/LC_MESSAGES/CN.po(1 hunks)holidays/locale/zh_CN/LC_MESSAGES/HK.po(1 hunks)holidays/locale/zh_CN/LC_MESSAGES/MO.po(2 hunks)holidays/locale/zh_HK/LC_MESSAGES/HK.po(1 hunks)holidays/locale/zh_MO/LC_MESSAGES/MO.po(2 hunks)holidays/locale/zh_TW/LC_MESSAGES/CN.po(1 hunks)scripts/l10n/generate_po_files.py(2 hunks)
🧰 Additional context used
🧠 Learnings (4)
holidays/locale/zh_MO/LC_MESSAGES/MO.po (2)
Learnt from: PPsyrius
PR: vacanza/holidays#2323
File: holidays/locale/zh_CN/LC_MESSAGES/MO.po:230-234
Timestamp: 2025-04-09T18:37:58.084Z
Learning: For Macau holidays localization, official Macau government sources (e.g., gov.mo) should be the reference for correct terminology, even when it differs from mainland Chinese standards.
Learnt from: PPsyrius
PR: vacanza/holidays#2323
File: holidays/locale/zh_CN/LC_MESSAGES/MO.po:230-234
Timestamp: 2025-04-09T18:37:58.084Z
Learning: For Macau's Simplified Chinese (zh_CN) localization, the term "重迭" is used on the official government website (gov.mo) for "overlapping" holidays, rather than the mainland standard "重叠".
holidays/locale/en_US/LC_MESSAGES/MO.po (1)
Learnt from: PPsyrius
PR: vacanza/holidays#2323
File: holidays/locale/zh_CN/LC_MESSAGES/MO.po:230-234
Timestamp: 2025-04-09T18:37:58.084Z
Learning: For Macau holidays localization, official Macau government sources (e.g., gov.mo) should be the reference for correct terminology, even when it differs from mainland Chinese standards.
holidays/locale/zh_CN/LC_MESSAGES/MO.po (2)
Learnt from: PPsyrius
PR: vacanza/holidays#2323
File: holidays/locale/zh_CN/LC_MESSAGES/MO.po:230-234
Timestamp: 2025-04-09T18:37:58.084Z
Learning: For Macau holidays localization, official Macau government sources (e.g., gov.mo) should be the reference for correct terminology, even when it differs from mainland Chinese standards.
Learnt from: PPsyrius
PR: vacanza/holidays#2323
File: holidays/locale/zh_CN/LC_MESSAGES/MO.po:230-234
Timestamp: 2025-04-09T18:37:58.084Z
Learning: For Macau's Simplified Chinese (zh_CN) localization, the term "重迭" is used on the official government website (gov.mo) for "overlapping" holidays, rather than the mainland standard "重叠".
holidays/locale/en_MO/LC_MESSAGES/MO.po (1)
Learnt from: PPsyrius
PR: vacanza/holidays#2323
File: holidays/locale/zh_CN/LC_MESSAGES/MO.po:230-234
Timestamp: 2025-04-09T18:37:58.084Z
Learning: For Macau holidays localization, official Macau government sources (e.g., gov.mo) should be the reference for correct terminology, even when it differs from mainland Chinese standards.
🧬 Code Graph Analysis (1)
scripts/l10n/generate_po_files.py (1)
scripts/generate_snapshots.py (1)
save(66-71)
⏰ Context from checks skipped due to timeout of 300000ms (2)
- GitHub Check: Build distribution
- GitHub Check: Test docs build
🔇 Additional comments (94)
holidays/locale/km/LC_MESSAGES/KH.po (3)
57-60: Improved Comment Consolidation for Birthday of His Majesty
Merging the previously split lines into one clear comment enhances readability and consistency.
69-72: Streamlined Comment for Birthday of Her Majesty
The consolidated comment now clearly describes the holiday in one line, making the file easier to read and maintain.
87-93: Enhanced Formatting for Coronation Day Comment
Consolidating the multi-line comment into a more concise format improves clarity. Please verify that the merged message string remains acceptable for your processing.holidays/locale/lv/LC_MESSAGES/LV.po (1)
38-42: Consolidated Comment for Latvian Hockey Achievement
Merging the split comment into a single line improves the clarity of the holiday description.holidays/locale/es/LC_MESSAGES/AR.po (1)
84-88: Improved Comment for Affirmation of Argentine Rights
The multiline comment has been consolidated into one line, enhancing readability while preserving the intended meaning.holidays/locale/th/LC_MESSAGES/TH.po (1)
274-277: Refined Comment for Additional Closing Day
The consolidation into a single line makes the comment about the bank’s additional closing day clearer and more maintainable.holidays/locale/th/LC_MESSAGES/BN.po (1)
104-109: Improved Comment Consolidation for Royal Wedding
Merging previously split comment lines into one concise comment enhances clarity and ensures consistency across the localization files.holidays/locale/uk/LC_MESSAGES/LV.po (1)
38-42: Enhanced Comment Formatting in Latvian LocalizationThe consolidation of the comment regarding the Latvian hockey team’s bronze medal achievement improves clarity and aligns perfectly with the PR’s objective of standardized comment formatting.
holidays/locale/en_US/LC_MESSAGES/CN.po (1)
92-98: Improved Consolidation of Anniversary CommentMerging the multi-line comment for the 70th Anniversary message into a single, streamlined line enhances readability and consistency in the en_US localization.
holidays/locale/de/LC_MESSAGES/DE.po (2)
85-90: Streamlined 75th Anniversary CommentThe updated comment for the 75th anniversary of the liberation from Nazism is now concise and clear, which supports the overall goal of uniform comment formatting.
91-96: Streamlined 80th Anniversary CommentLikewise, the consolidation of the 80th anniversary comment significantly improves consistency and readability in the German localization.
holidays/locale/th/LC_MESSAGES/RU.po (1)
65-68: Consolidated Declaration of Sovereignty CommentCombining the comment into a single line for the Declaration of Sovereignty enhances its clarity and ensures platform-independent formatting.
holidays/locale/zh_CN/LC_MESSAGES/CN.po (1)
92-98: Refined Anniversary Comment in Chinese LocalizationMerging the comment lines for the 70th Anniversary message into one clear line is a great improvement that aligns with the PR’s objective of enhancing message comment wrapping.
holidays/locale/ms/LC_MESSAGES/BN.po (1)
104-107: Consolidated Comment Update.
Merging the multi-line comment into a single, clear line for the "Royal Wedding of Crown Prince Al-Muhtadee Billah and Crown Princess Sarah of Brunei" entry improves consistency and readability.holidays/locale/uk/LC_MESSAGES/DE.po (1)
86-99: Unified Anniversary Comment Lines.
The comments for the 75th and 80th anniversary entries have been consolidated, which removes unnecessary line breaks and enhances clarity in the localization file.holidays/locale/zh_CN/LC_MESSAGES/HK.po (1)
190-194: Consolidated 70th Anniversary Comment.
The update to merge the two comment lines for the "70th Anniversary of the Victory of the Chinese People's War of Resistance against Japanese Aggression…" entry helps improve readability. Please verify that the complete message is preserved as intended.holidays/locale/zh_HK/LC_MESSAGES/HK.po (1)
190-194: Optimized Comment for 70th Anniversary.
The consolidation of the comment for the 70th Anniversary entry provides a cleaner presentation. Make sure the full context of the message is maintained without unintended truncation.holidays/locale/be/LC_MESSAGES/BY.po (2)
50-53: Improved Comment Formatting.
The comment for the National Coat of Arms entry has been reformatted to reduce extra line breaks, which results in a clearer and more concise description.
67-70: Streamlined Comment for Defenders' Day.
Consolidating the comment for "Day of the Fatherland's Defenders and the Armed Forces of the Republic of Belarus" into a single line enhances consistency across the localization files.holidays/locale/ru/LC_MESSAGES/RU.po (1)
66-69: Consolidated Comment Formatting:
The holiday comment for the adoption of sovereignty is now presented on one line instead of being split. This enhances clarity and is consistent with the new formatting guidelines.holidays/locale/en_US/LC_MESSAGES/TH.po (1)
1-120: Uniform Comment Consolidation:
All comment lines now follow a consistent single-line format, which improves readability and ensures platform-independent behavior. Great work on streamlining these entries!holidays/locale/zh_TW/LC_MESSAGES/CN.po (1)
92-93: Merged 70th Anniversary Comment:
The previously split comment for the 70th Anniversary of the Victory has been consolidated into one line. This change simplifies the comment structure and maintains consistency with other localizations.holidays/locale/zh_MO/LC_MESSAGES/MO.po (6)
181-185: Reformatted Handover Comment:
The comment regarding the Handover of Macau to China and the establishment of the Macau SAR has been consolidated. This single-line format improves clarity and aligns with our new formatting standards.
186-190: Merged Post-Handover Comment:
The comment for the day following Macau’s Handover is now unified, removing unnecessary line breaks for a cleaner appearance.
191-195: Consolidated 70th Anniversary Comment:
The two-line comment detailing the 70th Anniversary of the Victory has been merged into one concise line, enhancing overall readability.
227-230: Simplified Overlap Comment (National Day/Mid-Autumn):
The comment on the overlapping of the day following National Day and Mid-Autumn Festival is now consolidated, which makes it easier to read and maintain.
232-236: Condensed Overlap Comment (National Day/Double Ninth):
The reformatting of the overlapping holiday comment for National Day and Double Ninth Festival improves clarity by eliminating line breaks.
237-241: Unified Overlap Comment (National Day & Mid-Autumn):
The comment describing the overlap between National Day and the day following Mid-Autumn Festival has been merged, ensuring a uniform comment style across the file.holidays/locale/ru/LC_MESSAGES/BY.po (2)
50-55: Consolidated National Symbols Comment:
The comment for the national coat of arms, flag, and anthem now appears as a single unified line. This reformatting improves clarity without altering the translation content.
68-70: Unified Defenders Comment:
The comment for the day of the Fatherland’s defenders has been consolidated into one line, thus enhancing readability and matching the new formatting conventions.holidays/locale/en_US/LC_MESSAGES/HK.po (1)
190-196: Consolidated comment for 70th Anniversary is now clearer.
Merging the originally split comment lines into a more unified form enhances consistency and readability without affecting the translation content.holidays/locale/th/LC_MESSAGES/TL.po (1)
114-116: Improved comment for the FALINTIL holiday.
The consolidation into a single comment line makes it easier to understand and aligns well with similar updates in other localization files.holidays/locale/en_US/LC_MESSAGES/RU.po (1)
66-69: Unified comment for the Declaration of Sovereignty holiday.
Updating the comment into a single, clear line enhances clarity and matches the overall improved formatting standard applied across the project.holidays/locale/th/LC_MESSAGES/DE.po (1)
86-97: Refined anniversary comments for Germany localization.
The consolidation for both the 75th and 80th anniversary comments removes unnecessary line breaks and improves overall consistency and readability.holidays/locale/en_US/LC_MESSAGES/MO.po (6)
181-187: Enhanced Handover of Macau comment formatting.
The two-part comment describing the Handover of Macau and the establishment of the SAR is now merged seamlessly, which improves clarity.
188-194: Consolidated comment for the day following Macau's handover.
This update presents a clear, continuous explanation of the holiday, aligning perfectly with the broader refactor of comment formatting.
195-201: Unified comment for the 70th Anniversary holiday in Macau.
Merging the split comment lines into one concise description makes the intended message clearer while preserving the translation details.
233-239: Improved overlapping holiday comment for National Day and Mid-Autumn Festival.
The consolidation minimizes redundancy and improves readability, maintaining a consistent approach throughout the file.
240-246: Clear overlapping holiday comment for National Day and Double Ninth Festival.
This concise formatting effectively communicates the combined holiday information without unnecessary fragmentation.
247-253: Streamlined comment for National Day and the Day following Mid-Autumn Festival overlap.
By consolidating these comments, clarity is enhanced and the localization file remains consistent across similar entries.holidays/locale/en_US/LC_MESSAGES/MD.po (1)
58-58: Improved comment formatting for platform independenceThe modification standardizes the comment format by consolidating multi-line comments into a single line, ensuring consistent behavior across different platforms and translation tools.
holidays/locale/en_TL/LC_MESSAGES/TL.po (1)
114-114: Comment formatting standardizedGood job consolidating the comment about FALINTIL into a single line. This change maintains consistent formatting and helps ensure platform-independent handling.
holidays/locale/ro/LC_MESSAGES/MD.po (1)
58-61: Improved Comment Consolidation:
The comment for "Victory Day and Commemoration of the heroes fallen for Independence of Fatherland" is now consolidated into a single line. This enhancement improves clarity and fulfills the PR objective of standardized, platform-independent comment formatting.holidays/locale/en_US/LC_MESSAGES/DE.po (1)
86-99: Streamlined Anniversary Comments:
The comments for the 75th and 80th anniversaries have been reformatted into single continuous lines. This change makes the content more readable and consistent across the file, aligning well with the intended bug fix.holidays/locale/tet/LC_MESSAGES/TL.po (1)
114-116: Concise Holiday Comment:
The comment for "Day of the Armed Forces for the National Liberation of Timor-Leste (FALINTIL)" is now on a single line. This refined formatting enhances readability and meets the PR objective.holidays/locale/en_US/LC_MESSAGES/TL.po (1)
114-116: Consistent Commentary Format:
The consolidated comment for "Day of the Armed Forces for the National Liberation of Timor-Leste (FALINTIL)" ensures consistency with other localization files and improves overall clarity.holidays/locale/pt_TL/LC_MESSAGES/TL.po (1)
114-117: Enhanced Comment Clarity:
The comment for "Day of the Armed Forces for the National Liberation of Timor-Leste (FALINTIL)" has been merged into one concise line. While the formatting is now consistent, please ensure that themsgstris updated with the appropriate translation when available.holidays/locale/en_US/LC_MESSAGES/LV.po (1)
38-42: Consolidated comment formatting improves clarity.
The comment detailing the Latvian hockey team’s achievement has been merged into a single line, which enhances readability and ensures consistency in the localization file.holidays/locale/en_US/LC_MESSAGES/BY.po (2)
50-56: Improved comment consolidation for the National Coat of Arms holiday.
Merging the split comment lines into one continuous message improves clarity without altering the message content.
69-72: Consistent consolidation of comment for the Defender holiday.
This change unifies the comment into a single line, making it easier to read while preserving the intended meaning.holidays/locale/th/LC_MESSAGES/BY.po (2)
50-52: Consolidated comment for the National Coat of Arms holiday.
The two comment lines have been merged into one, resulting in a clearer and more unified message description.
67-69: Unified comment formatting for the Defender holiday.
By consolidating the descriptive lines into a single comment, readability and consistency in the Thai localization are improved.holidays/locale/uk/LC_MESSAGES/MD.po (1)
58-60: Streamlined comment for Victory Day and Commemoration.
Merging the previously split comment lines into one enhances clarity and aligns with the overall formatting improvements seen across the repository.holidays/locale/th/LC_MESSAGES/HK.po (1)
190-193: Consolidated comment for the 70th Anniversary holiday.
The previously separate comment lines have been merged into a single descriptive comment, ensuring clear and consistent documentation of the anniversary event.holidays/locale/uk/LC_MESSAGES/AR.po (3)
84-84: Excellent line wrapping cleanup in comments.The consolidation of multi-line comments into single lines improves readability and ensures platform-independent handling of comment lines.
243-243: Good consistent formatting of comments.Keeping this comment on a single line matches the pattern used throughout the file and improves consistency.
347-347: Well-structured comment formatting.This change maintains the consistent approach of single-line comments throughout the localization files.
holidays/locale/en_US/LC_MESSAGES/KH.po (3)
57-57: Good comment formatting change.Consolidating this royal title comment into a single line improves consistency and platform compatibility.
69-69: Appropriate comment structure.The single-line format for the Queen-Mother's title maintains consistency with other comment formatting changes.
87-88: Well-handled comment consolidation.Merging the two-line coronation day comment into a single line improves readability and consistency across files.
holidays/locale/en_US/LC_MESSAGES/BN.po (1)
104-104: Effective comment consolidation.The Royal Wedding comment is now properly formatted on a single line, improving consistency with other holiday descriptions.
holidays/locale/th/LC_MESSAGES/KH.po (3)
57-57: Good standardization of comment format.The single-line formatting of His Majesty's birthday comment matches the pattern used in other localization files.
71-71: Consistent comment formatting.This change maintains the single-line comment pattern established throughout the localization files.
91-92: Well-executed comment consolidation.Merging the coronation day comment into a single line improves consistency and readability across all localization files.
holidays/locale/en_US/LC_MESSAGES/AR.po (3)
84-87: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
243-245: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
347-349: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
holidays/locale/pt_MO/LC_MESSAGES/MO.po (6)
181-186: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
188-193: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
195-200: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
233-238: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
240-245: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
247-252: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
scripts/l10n/generate_po_files.py (3)
94-94: Added wrapwidth parameter for consistent formatting.Adding the wrapwidth parameter ensures consistent line wrapping in the generated .pot files, which addresses the core issue of platform-independent comment handling.
103-103: Added explicit newline parameter for cross-platform consistency.Explicitly setting newline to "\n" ensures consistent line endings across different platforms when saving the .pot files.
110-110: Added explicit newline parameter for cross-platform consistency.Explicitly setting newline to "\n" ensures consistent line endings across different platforms when saving the .po files.
holidays/locale/zh_CN/LC_MESSAGES/MO.po (6)
181-184: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
186-189: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
191-194: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files.
227-230: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files. I notice the translation correctly uses "重迭" rather than "重叠" for "overlapping", which aligns with Macau government terminology.
232-235: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files. The translation correctly uses "重迭" for "overlapping" following Macau's official terminology.
237-240: Consistent comment formatting applied.The holiday comment has been reformatted to a single line for better consistency across localization files. The translation maintains the correct Macau-specific terminology.
holidays/locale/en_MO/LC_MESSAGES/MO.po (6)
181-187: Consolidated Handover Comment
The reflow of the handover message now concatenates the two segments into a clear, single string. The trailing space at the end of the first segment ensures proper spacing between the parts. Nice work!
188-194: Reformatted Day-After Handover Comment
The message for the day following the handover has been neatly reflowed into two parts with proper concatenation. This improves readability and maintains the intended phrasing.
195-201: Unified 70th Anniversary Comment
The multi-line comment for the 70th Anniversary of the Victory has now been consolidated into a single coherent message. The spacing between the concatenated strings is correct and enhances clarity.
233-239: Simplified Overlapping Comment (National & Mid-Autumn)
The overlapping comment regarding National Day and Mid-Autumn Festival is now reflowed into a single cohesive message with clear spacing. This consolidation improves readability without altering the intended meaning.
240-246: Refined Overlapping Comment (National & Double Ninth)
The reformatting of the message for the overlap between National Day and Double Ninth Festival is well executed. The text is now split into two parts that join seamlessly, making it easier to follow.
247-253: Consistent Overlapping Message (National & Mid-Autumn)
The consolidation of the overlapping message for National Day and the day following Mid-Autumn Festival is consistent with the other reflow changes. The phrasing is clear and the formatting is correct.holidays/locale/th/LC_MESSAGES/MO.po (6)
181-185: Consolidated Handover Comment in Thai
The handover message has been reformatted into a single line in Thai. This improves clarity and maintains the original meaning while following the new line-wrapping guidelines.
186-190: Refined Day-After Handover Comment in Thai
The message for the day following the handover has been effectively consolidated. The reflow into a single, easy-to-read string enhances maintainability.
191-195: Unified 70th Anniversary Comment in Thai
The 70th Anniversary comment is now presented as a single line. The reformatting keeps the context intact, ensuring that the intended message comes through clearly in Thai.
227-231: Streamlined Overlapping Comment (National & Mid-Autumn) in Thai
The overlapping comment for National Day and Mid-Autumn Festival has been consolidated into one clear message. The reflow is consistent with similar changes in other locale files.
232-236: Overlapping Comment (National & Double Ninth) in Thai
The overlap message for National Day and the Double Ninth Festival now appears clean and succinct. The new formatting ensures that the message is easily readable while retaining its full meaning.
237-241: Consistent Overlapping Message (National Day & Post-Mid-Autumn) in Thai
The reflow of the overlapping message for National Day and the day following Mid-Autumn Festival is clear and consistent with the other changes. It enhances readability and aligns with the updated style.
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Makefile(2 hunks)tests/common.py(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (3)
- GitHub Check: Test build on windows-latest
- GitHub Check: Test build on macos-latest
- GitHub Check: Test build on ubuntu-latest
🔇 Additional comments (1)
Makefile (1)
21-24: Streamlined File Deletion in the Clean TargetThe new loop in the clean target smartly iterates over the file extensions (mo, pot, pyc), reducing redundancy compared to multiple find commands. The use of
$$extis correct in a Makefile context to escape the shell’s variable expansion. This improves maintainability and ensures that all relevant generated files are consistently removed.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
|
Proposed change
Update msg comments line wrapping (for platform-independent handling).
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green