Update IN holidays and localization #2259
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2259 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 204 204
Lines 12609 12809 +200
Branches 1809 1810 +1
==========================================
+ Hits 12609 12809 +200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@ankushhKapoor, good start! Are you planning to add other regional holidays? According to Wiki, there are a lot of them.
Thanks! Yep, I’m planning to add more regional holidays. The challenge is that each holiday falls on a different date every year, so I'm thinking of the most efficient approach to handle this. I'll add as many holidays as I can and will also include Hindi translations for each one. |
You can use the same approach as for Diwali, Holi etc. Later, if we implement support for Indian calendar (actually, calendars), it will be possible to refactor this similarly to other lunar calendars. |
Yes, I’m also thinking of doing the same. |
There was a problem hiding this comment.
I have (very) minor code formatting suggestions that we can surely address later. Let's get this amazing work merged!
LGTM!
@ankushhKapoor thanks for such a great contribution within WoC. I'm so glad we picked you and your idea among others. Nicely done 👍
@PPsyrius could you take a look at this too?
There was a problem hiding this comment.
LGTM 🇮🇳
@ankushhKapoor Thanks again for taking up such complex tasks
@arkid15r there's a merge conflict that needs to be manually solved
Not sure about this one 🤷♂️ upd: I guess you meant the conversations |
|
NVM, |
Happy Holi 🎉😄 |
|
Thanks a lot, everyone! I just cannot express the happiness I feel right now after getting my first PR merged! Really appreciate the support, feedback, and the kind words you all shared. |
Proposed change
This PR addresses Issues #2182 , #2183 enhancing the holiday dataset by incorporating state-specific holidays and regional variations. The goal is to provide a more comprehensive representation of holidays in India, covering a wider range of locations.
I am a Winter of Code (WoC) 2025 contributor and am excited to contribute to the project with these updates. Let me know if any further modifications are needed!
Resolves #2182 and #2183 .
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green