+
Skip to content

Do not build SELinux progs if libselinux is not installed #8759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Do not build SELinux progs if libselinux is not installed #8759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4439cdf
Do not build and test SELinux progs if disabled
oech3 Sep 28, 2025
7fc1918
test that SELinux is disabled, fix inverted flag
oech3 Sep 28, 2025
de1c619
Build SELinux progs if libselinux is installed
oech3 Sep 30, 2025
7aee294
Check that chcon exists if libselinux is installed even SELINUX_ENABL…
oech3 Sep 30, 2025
2538c9b
Update GNUmakefile
oech3 Sep 30, 2025
f1c4f5a
Fix typo to --exists
oech3 Sep 30, 2025
de7f244
Wording
oech3 Sep 30, 2025
e5a7c47
GNUmakefile: Minimize comment about libselinux
oech3 Oct 6, 2025
30c3afe
Merge branch 'main' into skipselinux
oech3 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/CICD.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,13 +298,15 @@ jobs:
run: make nextest CARGOFLAGS="--profile ci --hide-progress-bar"
env:
RUST_BACKTRACE: "1"
- name: "`make install COMPLETIONS=n MANPAGES=n`"
- name: "`make install COMPLETIONS=n MANPAGES=n SELINUX_ENABLED=0`"
shell: bash
run: |
set -x
DESTDIR=/tmp/ make PROFILE=release COMPLETIONS=n MANPAGES=n install
DESTDIR=/tmp/ make PROFILE=release COMPLETIONS=n MANPAGES=n SELINUX_ENABLED=0 install
# Check that the utils are present
test -f /tmp/usr/local/bin/tty
# Check that SELinux utils get installed if libselinux is installed, even with the parameter "SELINUX_ENABLED=0"
pkg-config --exists libselinux && test -f /tmp/usr/local/bin/chcon
# Check that the manpage is not present
! test -f /tmp/usr/local/share/man/man1/whoami.1
# Check that the completion is not present
Expand Down
8 changes: 3 additions & 5 deletions GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,13 @@ HASHSUM_PROGS := \

$(info Detected OS = $(OS))

# Don't build the SELinux programs on macOS (Darwin) and FreeBSD
ifeq ($(filter $(OS),Darwin FreeBSD),$(OS))
SELINUX_PROGS :=
# Build SELinux progs if libselinux is installed
ifeq ($(shell pkg-config --exists libselinux ; echo $$?),0)
PROGS := $(PROGS) $(SELINUX_PROGS)
endif

ifneq ($(OS),Windows_NT)
PROGS := $(PROGS) $(UNIX_PROGS)
# Build the selinux command even if not on the system
PROGS := $(PROGS) $(SELINUX_PROGS)
endif

UTILS ?= $(PROGS)
Expand Down
Loading
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载