+
Skip to content

Do not build SELinux progs if libselinux is not installed #8759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Do not build SELinux progs if libselinux is not installed #8759

wants to merge 8 commits into from

Conversation

oech3
Copy link
Contributor

@oech3 oech3 commented Sep 28, 2025

Closes #7996 .
Replaces #8729 using SKIP_UTILS also for skipping tests.

@sylvestre
Copy link
Contributor

could you please add tests to make sure we don't regress? thanks

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/chcon/chcon is now being skipped but was previously passing.
Note: The gnu test tests/install/install-C-selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/selinux is now being skipped but was previously passing.
Note: The gnu test tests/mkdir/restorecon is now being skipped but was previously passing.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8759 will not alter performance

Comparing oech3:skipselinux (e5a7c47) with main (1b74e7d)

Summary

✅ 79 untouched
⏩ 73 skipped1

Footnotes

  1. 73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/runcon/runcon-no-reorder. tests/runcon/runcon-no-reorder is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@oech3

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Contributor Author

oech3 commented Sep 30, 2025

Those bins are still needed by tests for non-SELinux env. Skipping them if libselinux is not installed passed all tests.
Please edit this if there is a better idea about test added at here before merging.

@oech3 oech3 changed the title Do not build and test SELinux progs if disabled Do not build SELinux progs if libselinux is not installed Sep 30, 2025
Ecordonnier
Ecordonnier reviewed Sep 30, 2025
View reviewed changes
@oech3 @Ecordonnier
Wording
de7f244 
uutils#8759 (comment)

Co-authored-by: Etienne Cordonnier <ecordonnier@snap.com>
Ecordonnier
Ecordonnier reviewed Sep 30, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@oech3 oech3 closed this Oct 4, 2025
@oech3 oech3 deleted the skipselinux branch October 4, 2025 07:39
@oech3 oech3 restored the skipselinux branch October 5, 2025 12:47
@oech3 oech3 reopened this Oct 5, 2025
@oech3
Copy link
Contributor Author

oech3 commented Oct 5, 2025

Not replaced by #8795

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ecordonnier Ecordonnier Ecordonnier left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure without libselinux (missing ifeq in GNUmakefile)

3 participants

@oech3 @sylvestre @Ecordonnier
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载