expr: Fix parsing negated character classes "[^a]" #7884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to track if the previous character was already escaped to determine if the '\' character should be interpreted as an escape character.
|
GNU testsuite comparison: |
cakebaker
reviewed
May 4, 2025
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
|
GNU testsuite comparison: |
|
Thanks! |
RenjiSann
pushed a commit
to RenjiSann/coreutils
that referenced
this pull request
May 23, 2025
* expr: Fix regex escape logic We have to track if the previous character was already escaped to determine if the '\' character should be interpreted as an escape character. * expr: Fix parsing caret (^) as character class negation token * expr: Add tests for parsing carets in regex * expr: Add missing semicolon * expr: Simplify boolean assignment Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
* expr: Fix regex escape logic We have to track if the previous character was already escaped to determine if the '\' character should be interpreted as an escape character. * expr: Fix parsing caret (^) as character class negation token * expr: Add tests for parsing carets in regex * expr: Add missing semicolon * expr: Simplify boolean assignment Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the logic for parsing carets (^) when used as a character class negation token. Also, the '' character is now only interpreted as an escape token if it is not already escaped.
Added tests to verify the caret parsing and escaping logic.
fixes #7880