This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): rule useKeyWithClickEvents
#3426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/jk-gan/rome-tools into feature/use-key-with-click-events
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
useKeyWithClickEvents
|
I've fixed the codes based on the suggestions. |
ematipico
approved these changes
Oct 14, 2022
| use rome_rowan::{declare_node_union, AstNode}; | ||
|
|
||
| declare_rule! { | ||
| /// Pair the `onClick` mouse event with the `onKeyUp`, the `onKeyDown`, or the `noKeyPress` keyboard event. |
There was a problem hiding this comment.
Suggested change
| /// Pair the `onClick` mouse event with the `onKeyUp`, the `onKeyDown`, or the `noKeyPress` keyboard event. | |
| /// Enforce to have the`onClick` mouse event with the `onKeyUp`, the `onKeyDown`, or the `noKeyPress` keyboard event. |
| fn run(ctx: &RuleContext<Self>) -> Self::Signals { | ||
| let node = ctx.query(); | ||
|
|
||
| let required_props = ["onKeyDown", "onKeyUp", "onKeyPress"]; |
There was a problem hiding this comment.
This can be a const of UseKeyWithClickEvents:
impl UseKeyWithClickEvents {
const REQUIRED_PROPS: [&str; 3] = ["onKeyDown", "onKeyUp", "onKeyPress"];
}
// ..
if Self::REQUIRED_PROPS.contains(&name.as_str()) {
return None;
}Like this, we don't need to create this array every time we run the rule.
|
It seems that the rule triggered in our code base :) That's good! Would you mind to fix it? |
|
I've updated the codes based on the suggestions |
ematipico
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3301 (Reopen the PR because #3372 is not able to detect the correct file change after I rebased with main branch)
Test Plan
Added various test cases