feat(rome_js_analyzer): rule `useKeyWithClickEvents` #3372

jk-gan · 2022-10-09T09:05:12Z

Summary

Test Plan

Added various test cases

netlify · 2022-10-09T09:05:16Z

👷 Deploy request for docs-rometools accepted.

Name	Link
🔨 Latest commit	`bb614f9`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/63495427aa9e560008e2e01d

jk-gan · 2022-10-09T09:06:42Z

if possible, could you please add hacktoberfest label to the PR?
because otherwise it won't be count for me.

…me#3251)

* feat(rome_analyze): use serde to deserialize rule settings * chore: code suggestions

leops · 2022-10-10T08:34:30Z

crates/rome_js_analyze/src/analyzers/nursery/use_key_with_click_events.rs

+    fn diagnostic(ctx: &RuleContext<Self>, _attr: &Self::State) -> Option<RuleDiagnostic> {
+        let node = ctx.query();
+
+        Some(RuleDiagnostic::new(


Could we add an additional footer note to explain why these attributes are required ?

ya sure, is there a way to add additional notes? or just add more explanations on the RuleDiagnostic?

Like this:

RuleDiagnostic::new(/* arguments */) .footer_note(markup!{"Additional text"}.to_owned());

xunilrj · 2022-10-10T14:10:44Z

crates/rome_js_analyze/src/analyzers/nursery/use_key_with_click_events.rs

+
+                match required_props
+                    .iter()
+                    .find_map(|key_event| element.find_attribute_by_name(key_event).ok().flatten())


find_attribute_by_name is kind a expensive function, probably makes more sense to do the inverse

let all_atts_present = element.attributes() .filter_map(|att| { let name = att.as_jsx_attribute()?.name().ok()?.as_jsx_name()?.value_token().trimmed_text(); if required_props.contains(name) { ... } } );

ematipico · 2022-10-10T14:15:51Z

if possible, could you please add hacktoberfest label to the PR? because otherwise it won't be count for me.

We'll check tomorrow internally if we are able to opt-in for hacktoberfest :)

…#3352)

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

…least 10 characters wide (rome#3396)

…ome#3400)

ematipico · 2022-10-11T14:51:25Z

if possible, could you please add hacktoberfest label to the PR? because otherwise it won't be count for me.

The team agreed to opt-in, we will have some issue for hacktoberfest

…e#3399)

* docs(website): small QoL for rules page * fix: version of the website * fix: outdated documentation * format

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

… pattern member union (rome#3408)

…me#3381) * feat(rome_analyze): use serde to deserialize rule settings * chore: code suggestions * feat(rome_js_analyze): handle serde errors inside `RuleContext` * chore: move to use `serde::Value` to avoid breaking deserialization * chore: merge from main * chore: code suggestions * chore: clippy * feat(rome_js_analyze): compute `AnalyzerOptions` from `Workspace` * chore: todo for track diagnostic error * chore: fix link * chore: fix test * chore: code suggestions

…3412) * fix(rome_diagnostics): fix unknown rule warning false positive * address PR review

… shutdown (rome#3417)

* fix(rome_cli): improve the main help text * address PR review

* feat(rome_js_analyze): new rule `noExplicitAny` * chore: address PR feedback * fix: version number * fix: update docs

…m/jk-gan/rome-tools into feature/use-key-with-click-events

jk-gan · 2022-10-14T12:30:23Z

hmmm I think the commits are messed up after I rebased. Let me open another PR and see if Github can detect the correct file change.

jk-gan · 2022-10-14T12:31:44Z

#3426 this PR is able to detect the correct file change

feat(rome_js_analyzer): rule useKeyWithClickEvents

ec4145c

jk-gan requested review from leops, ematipico and xunilrj as code owners October 9, 2022 09:05

jk-gan requested a review from a team October 9, 2022 09:05

denbezrukov and others added 3 commits October 10, 2022 09:28

fix(rome_js_formatter): in JSX, some spaces are removed rome#3211 (ro…

fb5b508

…me#3251)

feat(rome_analyze): use serde to deserialize rule settings (rome#3347)

148a539

* feat(rome_analyze): use serde to deserialize rule settings * chore: code suggestions

feat(rome_js_analyze): rule useValidAnchor (rome#3369)

e6dbf2a

leops reviewed Oct 10, 2022

View reviewed changes

ematipico and others added 2 commits October 10, 2022 11:04

feat(rome_js_analyze): new rule useBlankTarget (rome#3356)

d6b8949

fix(rome_formatter): Fill fits (rome#3374)

9ef58af

xunilrj reviewed Oct 10, 2022

View reviewed changes

MichaReiser and others added 12 commits October 10, 2022 16:48

fix(rome_js_parser): Export {"a"} from (rome#3380)

59aebe5

feat(rome_js_analyze): new rule noRestrictedGlobals (rome#3342)

6dbb67f

feat(rome_js_analyze): handle serde errors inside RuleContext (rome…

5058cf8

…#3352)

feat(rome_formatter): Measure unicode width (rome#3383)

afdad44

release: 0.10.1 (rome#3385)

2ffe2b7

fix(rome_diagnostics): fix the printing of empty diff lines (rome#3382)

f92fd06

feat(rome_analyzer): add noPositiveTabindex rule (rome#3336)

a4cc3b9

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

fix(rome_js_parser): Allow arguments in d.ts files (rome#3389)

ac43cf0

fix(rome_js_formatter): Arrow chain trailing comments (rome#3398)

b1b24b7

fix(rome_js_formatter): Fix dropped initializer comments (rome#3397)

193c2e0

fix(rome_diagnostics): force the diagnostics separator line to be at …

4b2f1da

…least 10 characters wide (rome#3396)

fix(rome_js_analyze): fix the debug bound checks of the CFG visitor (r…

a9aeb07

…ome#3400)

MichaReiser and others added 2 commits October 11, 2022 17:32

fix(rome_js_formatter): Fix arrow binding parameter in test call (rom…

828cdc2

…e#3399)

docs(website): small QoL for rules page (rome#3407)

4058d53

* docs(website): small QoL for rules page * fix: version of the website * fix: outdated documentation * format

MichaReiser and others added 13 commits October 12, 2022 14:07

perf(rome_formater): Inline FormatElement::Text (rome#3403)

2935526

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

feat(rome_js_formatter): Object Pattern Formatting (rome#3405)

1e66d03

fix(rome_js_syntax): Remove JsIdentifierBinding from object binding…

3767baf

… pattern member union (rome#3408)

fix(rome_diagnostics): fix unknown rule warning false positive (rome#…

10cbc0e

…3412) * fix(rome_diagnostics): fix unknown rule warning false positive * address PR review

fix(rome_cli): prevent the socket transport from printing an error on…

c01895e

… shutdown (rome#3417)

fix(rome_cli): improve the main help text (rome#3418)

e8f86ba

* fix(rome_cli): improve the main help text * address PR review

feat(rome_js_analyze): new rule noExplicitAny (rome#3413)

195d2f3

* feat(rome_js_analyze): new rule `noExplicitAny` * chore: address PR feedback * fix: version number * fix: update docs

fix(docs): set correct version for NoPositiveTabindex rule (rome#3422)

b89b143

refactor(rome_cli): Split CLI tests (rome#3419)

cc4d8d7

feat(rome_js_analyzer): rule useKeyWithClickEvents

82330ee

fix(rome_js_analyze): adjust rule based on suggestions

980aab3

Merge branch 'feature/use-key-with-click-events' of https://github.co…

bb614f9

…m/jk-gan/rome-tools into feature/use-key-with-click-events

jk-gan requested a review from MichaReiser as a code owner October 14, 2022 12:20

jk-gan closed this Oct 14, 2022

jk-gan mentioned this pull request Oct 14, 2022

feat(rome_js_analyzer): rule useKeyWithClickEvents #3426

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(rome_js_analyzer): rule `useKeyWithClickEvents` #3372

feat(rome_js_analyzer): rule `useKeyWithClickEvents` #3372

Uh oh!

jk-gan commented Oct 9, 2022 •

edited

Loading

Uh oh!

netlify bot commented Oct 9, 2022 •

edited

Loading

Uh oh!

jk-gan commented Oct 9, 2022

Uh oh!

leops Oct 10, 2022

Uh oh!

jk-gan Oct 12, 2022

Uh oh!

ematipico Oct 12, 2022 •

edited

Loading

Uh oh!

xunilrj Oct 10, 2022 •

edited

Loading

Uh oh!

ematipico commented Oct 10, 2022

Uh oh!

ematipico commented Oct 11, 2022

Uh oh!

jk-gan commented Oct 14, 2022

Uh oh!

jk-gan commented Oct 14, 2022

Uh oh!

Uh oh!

feat(rome_js_analyzer): rule useKeyWithClickEvents #3372

feat(rome_js_analyzer): rule useKeyWithClickEvents #3372

Uh oh!

Conversation

jk-gan commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

netlify bot commented Oct 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy request for docs-rometools accepted.

Uh oh!

jk-gan commented Oct 9, 2022

Uh oh!

leops Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

jk-gan Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

ematipico Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xunilrj Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ematipico commented Oct 10, 2022

Uh oh!

ematipico commented Oct 11, 2022

Uh oh!

jk-gan commented Oct 14, 2022

Uh oh!

jk-gan commented Oct 14, 2022

Uh oh!

Uh oh!

feat(rome_js_analyzer): rule `useKeyWithClickEvents` #3372

feat(rome_js_analyzer): rule `useKeyWithClickEvents` #3372

jk-gan commented Oct 9, 2022 •

edited

Loading

netlify bot commented Oct 9, 2022 •

edited

Loading

ematipico Oct 12, 2022 •

edited

Loading

xunilrj Oct 10, 2022 •

edited

Loading