+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_syntax): Remove JsIdentifierBinding from object binding pattern member union #3408

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix(rome_js_syntax): Remove JsIdentifierBinding from object binding pattern member union #3408

merged 1 commit into from
Oct 12, 2022

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Oct 12, 2022 •
edited
Loading

This PR removes the JsIdentifierBinding from the JsAnyObjectBindingPatternMember union. A single identifier is parsed as a JsObjectBindingPatternShorthandProperty and not as a JsIdentifierBinding.

I verified that the member union for JsObjectAssignmentPattern does not have a JsReferenceIdentifier variant.

@MichaReiser
fix(rome_js_syntax): Remove JsIdentifierBinding from object pattern…
32b9237 
… member

This PR removes the `JsIdentifierBinding` from the `JsAnyObjectBindingPatternMember` union. A single identifier is parsed as a `JsObjectBindingPatternShorthandProperty` and not as a `JsIdentifierBinding`.
@MichaReiser MichaReiser temporarily deployed to netlify-playground October 12, 2022 11:35 Inactive
@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited
Loading

✅ Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 32b9237
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6346a691cd0119000a0b1efb

@MichaReiser MichaReiser changed the title fix(rome_js_syntax): Remove JsIdentifierBinding from object pattern… fix(rome_js_syntax): Remove JsIdentifierBinding from object binding pattern member union Oct 12, 2022
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44939 44939 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1621 1621 0
Failed 4325 4325 0
Panics 0 0 0
Coverage 27.26% 27.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12395 12395 0
Failed 3862 3862 0
Panics 0 0 0
Coverage 76.24% 76.24% 0.00%

@github-actions
Copy link

Playground for commit c7b63e1

@MichaReiser MichaReiser marked this pull request as ready for review October 12, 2022 12:08
@MichaReiser MichaReiser requested a review from a team October 12, 2022 12:08
@MichaReiser MichaReiser added A-Parser Area: parser S-Bug: confirmed Status: report has been confirmed as a valid bug labels Oct 12, 2022
@MichaReiser MichaReiser added this to the 10.0.0 milestone Oct 12, 2022
@MichaReiser MichaReiser added the I-Easy Implementation: easy task, usually a good fit for new contributors label Oct 12, 2022
@MichaReiser MichaReiser merged commit 3767baf into main Oct 12, 2022
@MichaReiser MichaReiser deleted the fix/object-binding-member-definition branch October 12, 2022 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
A-Parser Area: parser I-Easy Implementation: easy task, usually a good fit for new contributors S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Rome 2022
Status: Done
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载