+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_syntax): Remove JsIdentifierBinding from object binding pattern member union #3408

Merged
merged 1 commit into from
Oct 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ fn traverse_binding(
return pattern.properties().into_iter().find_map(|prop| {
let prop = prop.ok()?;
match prop {
JsAnyObjectBindingPatternMember::JsIdentifierBinding(id_binding) => {
track_binding(&id_binding, tracked_bindings).then_some(id_binding)
}
JsAnyObjectBindingPatternMember::JsObjectBindingPatternProperty(pattern) => {
let pattern = pattern.pattern().ok()?;
traverse_binding(pattern, tracked_bindings)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ impl FormatRule<JsAnyObjectBindingPatternMember> for FormatJsAnyObjectBindingPat
JsAnyObjectBindingPatternMember::JsObjectBindingPatternShorthandProperty(node) => {
node.format().fmt(f)
}
JsAnyObjectBindingPatternMember::JsIdentifierBinding(node) => node.format().fmt(f),
JsAnyObjectBindingPatternMember::JsUnknownBinding(node) => node.format().fmt(f),
}
}
Expand Down
25 changes: 2 additions & 23 deletions crates/rome_js_syntax/src/generated/nodes.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion xtask/codegen/js.ungram
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,6 @@ JsAnyObjectBindingPatternMember =
JsObjectBindingPatternProperty
| JsObjectBindingPatternRest
| JsObjectBindingPatternShorthandProperty
| JsIdentifierBinding
| JsUnknownBinding

// let { a: b.m } = {}
Expand Down
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载