This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_semantic): add TsTypeParameterName to bindings
#4259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
6d1fa5c to
003176e
Compare
ematipico
commented
Mar 4, 2023
| if binding | ||
| .syntax() | ||
| .ancestors() | ||
| .find(|node| TsMethodSignatureClassMember::can_cast(node.kind())) |
There was a problem hiding this comment.
Function overloadings belong to the same scope, and bindings inside function overloadings should be ignored when checking for re-declarations.
003176e to
c864470
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When #4053 was merged, it unveiled an issue in our semantic model.
The CI didn't fail because it doesn't run some script, but the command
checkwas failing on such codes:This PR fixes the issue, where we track
keyas bindings.Test Plan
Added a new test case
Documentation