This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): implement rule noRedeclaration, no-redeclare #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
xunilrj
reviewed
Dec 14, 2022
| type Options = (); | ||
|
|
||
| fn run(ctx: &RuleContext<Self>) -> Self::Signals { | ||
| let mut duplicates = Duplicates::default(); |
There was a problem hiding this comment.
Nit: Not sure there is value hiding that this is a HashMap here.
let mut duplicates = HashMap::default();seems clearer to me.
xunilrj
reviewed
Dec 14, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 14, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 14, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 14, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 18, 2022
|
@edvardchen could you please comment on #3990 so I can assign that to you? |
leops
reviewed
Dec 21, 2022
| let model = ctx.model(); | ||
| let bindings = model.scope(ctx.query().syntax()).bindings(); | ||
| for binding in bindings { | ||
| let name = binding.tree().text(); |
There was a problem hiding this comment.
Nit: you could use binding.tree().name_token().ok()?.text_trimmed() to use an &str as key and avoid allocating a String
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_redeclaration.rs
Outdated
Show resolved
Hide resolved
|
This PR is stale because it has been open 14 days with no activity. |
ematipico
approved these changes
Feb 16, 2023
|
@edvardchen Thanks for your contribution :) In order to merge your contribution, you have to rebase your branch on main in order to solve the current conflicts. |
feat(rome_js_analyze): implement rule no_redeclaration feat(rome_js_analyze): update document about noRedeclaration feat(rome_js_analyze): link the first binding in diagnostic for rule no_redecleration test(rome_js_analyze): add testcases for no_redeclaration fix(rome_js_analyze): fix lint error docs(rome_js_analyze): update document feat(rome_js_analyze): don't handle shadow globals in no_redeclaration feat(rome_js_analyze): create scope for static initialization blocks feat(rome_js_analyze): remove duplicated warnings for rule no_redeclaration chore(rome_js_analyze): rename the union type in no_redeclaration docs(rome_js_analyze): add suggestions for no_redeclaration refactor(rome_js_analyze): iterate all scopes for no_redeclaration fix(rome_js_semantic): fix duplicated patterns
5d67920 to
9c21cbe
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implement noRedeclaration https://eslint.org/docs/latest/rules/no-redeclare. Fixes #3990
Test Plan
have run
just codegenjust test-lintrule no_redeclarationjust documentationjust check-readyDocumentation
Caveats