+
Skip to content

fix: Discussion from #5 - use a getter and property instead of a return parameter #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025

Conversation

ralflang
Copy link
Member

@ralflang ralflang commented Jun 19, 2025

See also #5 - We should really not use return parameters. Forms is already confusing enough.

As recommended there:

  • Callers need to upgrade getInfo(...) to $info = getInfo(...) where this has not happened yet
  • derived types need to return array $info in getInfo
  • Callers need to add getMessage after isValid if they actually use the message
  • derived types need to set $this->message before return if they actually set a message
  • Let's draft a largely compatible V3 namespaced versions if the breaks proposed by @amulet1 in fix: Correct Horde_Form_Type::isValid() signature #5
  • Let's keep more involved changes for V4 with PHP 8.4 baseline

@ralflang ralflang merged commit 99aec68 into FRAMEWORK_6_0 Jun 20, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载