I'm not so fond of this approach. Alternatives:

• Store a property $invalidMessage either with a read hook (PHP 8.4+ only) or with a getter (universally possible)
• Emit a rich object if valid.

As for the getInfo, we have made virtually all getInfo usages return the value and read the return value. Let me look up any leftovers.

In this case $message parameter should be dropped altogether.

And all the callers should be updated to retrieve the property, if it is needed.

getInfo still needs to be fixed ($infoparameter should be dropped too).

I would like to offer my help with the changes. Please advise.

Help is much appreciated. However we should be careful with timing.

Changing signatures again in a base class which is littered all over horde and external products needs a bit of care. We want to go beta next week and stable in July. Let's work on Forms 4 with a proper OO model and then upgrade apps step by step in a .1 feature release.

Well, right now it is broken - $message is not returned at all. It has to be fixed.

Maybe we can do it in stages:

1. Make $message parameter optional. Potentially log warning/stack trace if the argument count includes the optional parameter.
2. Eliminate it on the caller's end, update code to retrieve $message property where needed. This can take some time.
3. Finally remove $message parameter.

Same can be done with getInfo. Not sure if there are other places like that, as I just looked at the very recent commits that were not working for me.

Yes, let's do it in stages.

• Callers may upgrade right now:

// old:
$form->getInfo($vars, $info)
$type->getInfo($vars, $info);
$bValid = $type->isValid($var, $vars, $value, $message);

// new:
$info = $form->getInfo($vars);
$info = $type->getInfo($vars, $info);
$bValid = $type->isValid($var, $vars, $value, $message);
$message = $type->getMessage();

Let's implement the incompatible, better type system in the PSR-4 namespace (src folder)

src/V3/Types/Text.php

$info = $form->getInfo($vars);
$info = $type->getInfo($vars);
$bValid = $type->isValid($var, $vars, $value);
$message = $type->getMessage();

This way

• caller code than upgrade to TypesV3 at their own pace
• There is no hard break. Most code I tested is already upgraded for the crucial getInfo functionality. The $message functionality can be updated one library/app at a time either to just add the getMessage line (right now) or to use the new signature (as soon as we have that)
• All progressively possible before July i.e. before the Horde 6 mainline release or after. No time pressure.
• A more involved V4 redesign can coexist.

Superseded by #6 - Let's do it in stages.