+
Skip to content

Conversation

ganeshkumarsv
Copy link
Contributor

Update active committers struct to include additional attributes.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (66567f8).
Report is 106 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
- Coverage   97.72%   92.94%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11663    -1727     
==========================================
- Hits        13085    10840    -2245     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganeshkumarsv
Copy link
Contributor Author

@gmlewis can you please take a look when you have time? I added all the introduced attributes into the test case, I'm not sure why the code coverage still fails.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 5, 2024

@gmlewis can you please take a look when you have time? I added all the introduced attributes into the test case, I'm not sure why the code coverage still fails.

Thank you, @ganeshkumarsv !
Yes, we currently have an issue with CodeCov where we need the token in this repo to be updated for it to work again.
For details, see: #3221

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ganeshkumarsv !
LGTM.
Merging.

@gmlewis gmlewis merged commit bd3e889 into google:master Sep 5, 2024
6 of 7 checks passed
@ganeshkumarsv
Copy link
Contributor Author

Thank you for merging @gmlewis 🙇. Is it possible to create a new release?

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 5, 2024

Thank you for merging @gmlewis 🙇. Is it possible to create a new release?

Our next release will probably be in a couple weeks.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 16, 2024

This has now been released: https://github.com/google/go-github/releases/tag/v65.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载