+
Skip to content

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jul 29, 2024

No description provided.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (fb71c47).
Report is 224 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
- Coverage   97.72%   92.94%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11633    -1757     
==========================================
- Hits        13085    10812    -2273     
- Misses        215      727     +512     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 29, 2024

This does NOT solve the problem because codecov appears to be using a very old commit as the BASE:
https://app.codecov.io/gh/google/go-github/commit/2b8c7fa86fcd1cb4a89a44c8e7b5a49fe4be8a45

After more investigation, I found this thread:
https://community.codecov.com/t/incorrect-base-commit-of-pull-request/1779/2

However, its "solution" was solved in a private conversation. I'll try adding to the thread.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 29, 2024

According to this: codecov/feedback#123
It may be that the codecov token being used is out-of-date?!?

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 29, 2024

This issue also mentions the codecov token: codecov/feedback#144

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jul 29, 2024

@google-admin - when you get a chance can you please make sure that this repo's CODECOV secret repo token is up-to-date?

According to all the similar issues I could find (linked above), they say that an old CODECOV token could be the cause of it choosing very old (6-months ago) BASE commits to compare against.

Thank you!

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Sep 16, 2024

@google-admin - when you get a chance can you please make sure that this repo's CODECOV secret repo token is up-to-date?

According to all the similar issues I could find (linked above), they say that an old CODECOV token could be the cause of it choosing very old (6-months ago) BASE commits to compare against.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载