Singular integration #2637
Merged
Singular integration #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughA new Singular integration was implemented, including webhook endpoints, event tracking, and URL handling. Core lead and sale tracking logic was refactored into reusable functions, simplifying API route handlers. Type definitions were standardized and decoupled from Zod schemas. Middleware and utility functions were updated to support Singular-specific tracking and URL patterns. Minor improvements and adjustments were made to page caching, error logging, and integration scripts. Changes
Sequence Diagram(s)Singular Webhook Event FlowsequenceDiagram
participant Singular
participant API as /api/singular/webhook
participant DB as Database
participant Lead as trackLead
participant Sale as trackSale
Singular->>API: GET /api/singular/webhook?...
API->>API: Validate SINGULAR_WEBHOOK_TOKEN and query params
API->>DB: Lookup workspace by dub_workspace_id
API->>API: Map event_name to internal type
alt event_name == "lead"
API->>Lead: trackLead(params, workspace)
Lead-->>API: Lead tracking result
else event_name == "sale"
API->>Sale: trackSale(params, workspace)
Sale-->>API: Sale tracking result
end
API-->>Singular: JSON { "OK": true }
Lead/Sale Tracking DelegationsequenceDiagram
participant Route as /api/track/lead or /api/track/sale
participant Logic as trackLead/trackSale
participant DB as Database
participant Redis as Redis
participant Webhook as Workspace Webhook
Route->>Logic: Call with parsed params and workspace
Logic->>Redis: Deduplication (lead/sale)
Logic->>DB: Lookup or upsert customer/lead/sale
Logic->>Webhook: Send event notification
Logic-->>Route: Tracking result
Route-->>Client: JSON response
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learningsapps/web/app/app.dub.co/(dashboard)/[slug]/settings/(basic-layout)/integrations/[integrationSlug]/manage/page.tsx (1)🧬 Code Graph Analysis (1)apps/web/app/app.dub.co/(dashboard)/[slug]/settings/(basic-layout)/integrations/[integrationSlug]/manage/page.tsx (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ic, remove deprecated functions, and enhance error handling. Introduce new trackLead and trackSale functions for improved event processing.
…nt trackSale function for sale event processing. Refactor sale tracking logic in Singular integration to enhance clarity and maintainability.
…ransformation, add metadata parameter to trackLead and trackSale functions for improved data handling.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/lib/api/conversions/track-lead.ts (1)
74-76: Simplify nested property access with optional chaining.The current nested property access can be simplified using optional chaining for better readability and safety.
- if (clickEvent && clickEvent.data && clickEvent.data.length > 0) { + if (clickEvent?.data?.length > 0) { clickData = clickEvent.data[0]; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/app/(ee)/api/track/lead/route.ts(2 hunks)apps/web/lib/api/conversions/track-lead.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: devkiran
PR: dubinc/dub#2637
File: apps/web/app/(ee)/api/singular/webhook/route.ts:0-0
Timestamp: 2025-07-17T06:41:45.598Z
Learning: In the Singular integration (apps/web/app/(ee)/api/singular/webhook/route.ts), the event names in the singularToDubEvent object have intentionally different casing: "Copy GAID" and "copy IDFA". This casing difference is valid and should not be changed, as these are the correct event names expected from Singular.
apps/web/lib/api/conversions/track-lead.ts (1)
Learnt from: devkiran
PR: dubinc/dub#2637
File: apps/web/app/(ee)/api/singular/webhook/route.ts:0-0
Timestamp: 2025-07-17T06:41:45.598Z
Learning: In the Singular integration (apps/web/app/(ee)/api/singular/webhook/route.ts), the event names in the singularToDubEvent object have intentionally different casing: "Copy GAID" and "copy IDFA". This casing difference is valid and should not be changed, as these are the correct event names expected from Singular.
🧬 Code Graph Analysis (1)
apps/web/app/(ee)/api/track/lead/route.ts (1)
apps/web/lib/api/conversions/track-lead.ts (1)
trackLead(28-288)
🪛 Biome (1.9.4)
apps/web/lib/api/conversions/track-lead.ts
[error] 74-74: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
🔇 Additional comments (8)
apps/web/app/(ee)/api/track/lead/route.ts (2)
1-1: Excellent refactoring approach!The centralization of lead tracking logic into a dedicated module improves maintainability and follows good separation of concerns.
44-58: Clean delegation to centralized tracking function!The refactored implementation correctly passes all necessary parameters to the centralized
trackLeadfunction and maintains the same API contract. This approach improves code maintainability while preserving all original functionality.apps/web/lib/api/conversions/track-lead.ts (6)
23-26: Well-structured type definitions!The
TrackLeadParamstype properly extends the Zod schema input while adding the necessaryrawBodyandworkspaceproperties for the internal function. This ensures type safety throughout the tracking workflow.
41-59: Robust deduplication implementation!The Redis-based deduplication logic is well-designed with:
- Proper cache key structure including workspace, customer, and event name
- Appropriate 1-week expiration to prevent indefinite storage
- NX flag to ensure atomic duplicate prevention
- String normalization correctly uses
replaceAllfor multiple spaces
104-148: Well-structured database operations!The helper functions are excellently designed:
upsertCustomerproperly handles both creation and update scenarioscreateLeadEventPayloadefficiently supports multiple event quantities with unique IDs- Clean separation of concerns improves maintainability
152-189: Excellent async/sync mode handling!The implementation properly differentiates between synchronous and asynchronous modes:
- "wait" mode executes customer creation and lead recording synchronously for immediate consistency
- "async" mode defers operations to background processing for better performance
- Proper use of
waitUntilfor serverless environments
191-264: Comprehensive background processing workflow!The background processing efficiently handles all necessary operations:
- Proper parallelization of link updates, workspace usage, and conversion logging
- Conditional partner commission creation with appropriate checks
- Avatar persistence to R2 storage with proper dimensions
- Webhook dispatch with transformed event data
268-288: Well-structured response with backwards compatibility!The response formatting properly:
- Validates response structure with Zod schema
- Maintains API consistency for existing clients
- Includes backwards compatibility fields with clear deprecation comments
- Provides clean migration path for future API updates
steven-tey
approved these changes
Jul 18, 2025
This was referenced Jul 21, 2025
Closed
Merged
This was referenced Jul 29, 2025
This was referenced Aug 13, 2025
This was referenced Aug 21, 2025
Merged
Merged
This was referenced Oct 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores