feat: Show broadcast channels in their own, proper "Channel" chat #6901

Hocuri · 2025-06-04T13:33:13Z

Part of #6884

Note that I removed the following guard:

        if !new_chat_contacts.contains(&ContactId::SELF) {
            warn!(
                context,
                "Received group avatar update for group chat {} we are not a member of.", chat.id
            );
        } else if !new_chat_contacts.contains(&from_id) {
            warn!(
                context,
                "Contact {from_id} attempts to modify group chat {} avatar without being a member.",
                chat.id,
            );
        } else [...]

i.e. with this change, non-members will be able to modify the avatar. Things were slightly easier this way, and I think that this is in line with non-members being able to modify the group name and memberlist (they need to know the Group-Chat-Id, anyway), but I can also change it back.

iequidoo · 2025-06-24T23:08:48Z

Consistently calling them BcChannel/bc_channel in the code would be both short and greppable, but a bit arcane when reading it at first. Opinions are welcome; if I hear none, I'll keep with BroadcastChannel.

My preference would be {In,Out}Broadcast because Broadcast is removed anyway, so those names won't conflict with it. But if ...Channel is necessary, then i'd go for {In,Out}BcChannel or even {In,Out}Bchannel because {In,Out}BroadcastChannel is really long and causes line wrapping and more scrolling for readers.

Make it possible to set the avatar of an OutgoingChannel, and apply it on the receiving side

Just in case, duplicated entry in the description.

When the user changes the broadcast channel name, immediately show this change on receiving devices

Maybe also allow renaming incoming broadcasts like it's done for mailing lists? It would cost two LOCs (and probably no additional UI work). While renaming broadcasts may not be possible in other messengers, it may help users to origanize and search broadcasts. EDIT: Then we need to resolve name conflicts if a broadcast is renamed by the sender. Let's skip renaming incoming broadcast for now at least.

adbenitez · 2025-06-26T22:42:33Z

I want to merge this only after #6796 is merged, but until then, this can already be reviewed

that one got already merged! 🎉

Hocuri · 2025-06-30T17:10:14Z

@link2xt was also in favor of {In|Out}Broadcast, so, I renamed them.

Cargo.toml

deltachat-jsonrpc/src/api.rs

deltachat-jsonrpc/src/api/types/chat_list.rs

deltachat-jsonrpc/src/api.rs

src/receive_imf.rs

src/constants.rs

src/test_utils.rs

deltachat-jsonrpc/src/api.rs

src/chat.rs

src/contact.rs

src/receive_imf.rs

where the former is similar to a `Mailinglist` and the latter is similar to a `Broadcast` (which is removed)

…how this change on receiving devices

src/chat.rs

src/receive_imf.rs

src/contact.rs

…list pseudo-contacts

iequidoo · 2025-07-02T15:56:06Z

deltachat-rpc-client/tests/test_something.py

+    assert not bob_chat_snapshot.is_unpromoted
+    assert bob_chat_snapshot.is_encrypted
+    assert bob_chat_snapshot.chat_type == ChatType.IN_BROADCAST
+


Shouldn't it be checked that the broadcast chat is in a "Request" state and can be unblocked by Bob?

iequidoo · 2025-07-02T16:02:31Z

i.e. with this change, non-members will be able to modify the avatar. Things were slightly easier this way, and I think that this is in line with non-members being able to modify the group name and memberlist (they need to know the Group-Chat-Id, anyway), but I can also change it back.

Missed this. I think it's a bug that non-members can modify the group name, at least i'd forbid that and see which tests fail. EDIT: At least removed members know Group-Chat-Id, but they mustn't be able to modify the chat.

Hocuri · 2025-07-02T20:25:04Z

Allowing non-members to modify the group is a deliberate trade-off, in order to be more resilient against message reordering: If a group member modifies the group, and is added to the group only afterwards (because the member-addition message arrived late), then it's nice if this group-edit is applied. IIRC, non-members can even modify the memberlist, and add themselves. DC is meant to be a private messenger, rather than one to chat with untrusted people (e.g. there are no group admins), so, being resilient against message reordering was considered more important than protecting against a removed contact editing your group.

But discussing about this is out of scope for this PR.

…te_broadcast_channel() In #6901, I unfortunately forgot to document the API change when rebasing. The API change is breaking because not adapting to the new channel types would lead to errors.

…te_broadcast_channel() In #6901, I unfortunately forgot to document the API change when squash-merging. The API change is breaking because not adapting to the new channel types would lead to errors.

Older versions of Delta Chat will ignore the message if it contains a ChatGroupId header. ("older versions" means all versions without #6901, i.e.currently released versions)

…te_broadcast_channel() (#6901) In #6901, I unfortunately forgot to document the API change when squash-merging, so, I'm doing this with the PR here. The API change is breaking because not adapting to the new channel types would lead to errors.

Older versions of Delta Chat ignore the message if it contains a ChatGroupId header. ("older versions" means all versions without #6901, i.e.currently released versions) This means that without this PR, broadcast channel messages sent from current main don't arrive at a device running latest released DC. Part of #6884.

Hocuri changed the base branch from main to link2xt/pgp-contacts June 4, 2025 13:33

This was referenced Jun 4, 2025

Show channels in a proper "Channel" chat deltachat/deltachat-android#3783

Merged

[Tracking issue] End-to-End encrypted Broadcast Channels #6884

Open

Hocuri changed the title ~~[WIP] Show channels in their own chat~~ [WIP] Show broadcast channels in their own, proper "Channel" chat Jun 15, 2025

Hocuri force-pushed the hoc/channels branch 2 times, most recently from 48fd8ec to 12bb5aa Compare June 23, 2025 13:42

Hocuri changed the title ~~[WIP] Show broadcast channels in their own, proper "Channel" chat~~ Show broadcast channels in their own, proper "Channel" chat Jun 23, 2025

Hocuri requested review from link2xt and iequidoo June 23, 2025 13:44

Base automatically changed from link2xt/pgp-contacts to main June 26, 2025 14:06

link2xt force-pushed the main branch 2 times, most recently from 285d80a to 416131b Compare June 26, 2025 14:07

Hocuri force-pushed the hoc/channels branch from 12bb5aa to 2e5aec5 Compare June 30, 2025 12:29

link2xt reviewed Jun 30, 2025

View reviewed changes

Hocuri changed the title ~~Show broadcast channels in their own, proper "Channel" chat~~ feat: Show broadcast channels in their own, proper "Channel" chat Jun 30, 2025

iequidoo reviewed Jul 1, 2025

View reviewed changes

Hocuri force-pushed the hoc/channels branch 2 times, most recently from 634086f to 8cd4130 Compare July 1, 2025 19:57

Hocuri added 9 commits July 1, 2025 22:14

api: Add create_broadcast_channel(), deprecate create_broadcast_list()

ba46cea

Add new chat types InBroadcastChannel and OutBroadcastChannel`, …

7c21835

where the former is similar to a `Mailinglist` and the latter is similar to a `Broadcast` (which is removed)

api: Add is_out_broadcast_channel, deprecate is_broadcast

90e1de6

feat: Actually create a channel when receiving, small improvements

387a2c5

feat: Allow to set channel profile image on receiving side

c0f21b7

feat: When the user changes the broadcast channel name, immediately s…

2c02dd0

…how this change on receiving devices

test: Add test_broadcast_channels()

1f9b402

test: Fix tests, all tests pass again now

71b3879

feat: Allow to set broadcast channel avatar

34c7655

Hocuri added 6 commits July 1, 2025 22:15

link2xt's review

be64f4b

docs: small changes after self-review

1448bcb

test: Improve tests

f56f78e

api: Add python API for broadcast lists, properly document chat types

04bd3be

iequidoo's review

296c334

test: Add basic python test for broadcasts

34023ba

Hocuri force-pushed the hoc/channels branch from 8cd4130 to 34023ba Compare July 1, 2025 20:15

Hocuri requested review from link2xt and iequidoo July 1, 2025 21:22

iequidoo reviewed Jul 2, 2025

View reviewed changes

src/chat.rs Outdated Show resolved Hide resolved

src/receive_imf.rs Show resolved Hide resolved

src/contact.rs Show resolved Hide resolved

Hocuri added 3 commits July 2, 2025 17:03

docs: fix typo

c5cec0e

Use default name rather than mailinglist name for broadcast list

943335f

Document why we put Blocked_broadcast as the fingerprint of mailing…

1e80128

…list pseudo-contacts

iequidoo approved these changes Jul 2, 2025

View reviewed changes

test: Check that new broadcast channel is contact request

aa170a8

Hocuri enabled auto-merge (squash) July 2, 2025 20:31

Hocuri merged commit 0a73c2b into main Jul 2, 2025
29 checks passed

Hocuri deleted the hoc/channels branch July 2, 2025 20:40

This was referenced Jul 3, 2025

Adapt to new Broadcast Channel chat types deltachat/deltachat-ios#2762

Closed

Adapt to new Broadcast Channel chat types deltachat/deltachat-desktop#5258

Open

Hocuri mentioned this pull request Jul 3, 2025

api!: Add InBroadcastChannel, OutBroadcastChannel chattypes, add create_broadcast_channel() (#6901) #6974

Merged

Hocuri mentioned this pull request Jul 3, 2025

fix: Don't send ChatGroupId for broadcast channels #6975

Merged

iequidoo mentioned this pull request Jul 4, 2025

feat: Don't apply chat name and avatar changes from non-members #6976

Merged

Uh oh!

feat: Show broadcast channels in their own, proper "Channel" chat #6901

feat: Show broadcast channels in their own, proper "Channel" chat #6901

Uh oh!

Conversation

Hocuri commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iequidoo commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adbenitez commented Jun 26, 2025

Uh oh!

Hocuri commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iequidoo Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

iequidoo commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hocuri commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hocuri commented Jun 4, 2025 •

edited

Loading

iequidoo commented Jun 24, 2025 •

edited

Loading

iequidoo commented Jul 2, 2025 •

edited

Loading

Hocuri commented Jul 2, 2025 •

edited

Loading