+
Skip to content

fix: Don't send ChatGroupId for broadcast channels #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Jul 3, 2025

Older versions of Delta Chat ignore the message if it contains a ChatGroupId header. ("older versions" means all versions without #6901, i.e.currently released versions)

This means that without this PR, broadcast channel messages sent from current main don't arrive at a device running latest released DC.

Part of #6884.

Older versions of Delta Chat will ignore the message if it contains a
ChatGroupId header. ("older versions" means all versions without #6901,
i.e.currently released versions)
Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, the List-ID header isn't "known" by mimeparser, so if it appears (or attached by an attacker) in the IMF section, it won't be overriden by List-ID in the encrypted part. This should be fixed

@Hocuri Hocuri merged commit aad8f69 into main Jul 7, 2025
29 checks passed
@Hocuri Hocuri deleted the hoc/channels-dont-send-groupid branch July 7, 2025 10:06
@Hocuri
Copy link
Collaborator Author

Hocuri commented Jul 7, 2025

I created a follow-up: #6983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载