fix(core): fix type inference of this
#6942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba548cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
this
this this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #6939. This bug was introduced in #6901 hastily merged without review.
In the implementation proposed below, biome uses a simple inference algorithm. We iterate over all ancestors of
thisexpr and apply the following checks:function(only sync/asyncfunctiondeclaration/expression, not methods) and is not used as a class/object member, we assignunknown.thisto it.functionor an object method/getter/setter, we bindthisto object.If no node matched any of those steps, we also assign
unknown.Test Plan
Added several snapshot tests relying on basic inference to prove that type of
thisis deduced correctly.Docs
Bugfix, N/A