fix(core): fix type inference of this
#6901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 794c6f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3a767b6 to
794c6f5
Compare
Merged
arendjr
added a commit
to arendjr/biome
that referenced
this pull request
Jul 16, 2025
sterliakov
reviewed
Jul 16, 2025
|
|
||
| impl TypeofThisOrSuperExpression { | ||
| fn from_any_js_expression(scope_id: ScopeId, expr: &AnyJsExpression) -> Self { | ||
| let binds_this = |node: &JsSyntaxNode| { |
There was a problem hiding this comment.
I shared this change as a patch (instead of PR) because that's still not how this works:( This was a really lazy minimal filter I wrote as a POC, not a real solution. For example,
class A {
const a = 1;
const b = this.a;
}
does not have any functions, and yet this in this.a is resolved correctly to the enclosing class... Could you at least add a // TODO somewhere here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #6777: Fixed type inference handling of
thisto avoid infinite recursion.Thanks to @sterliakov for the thorough investigation!
Test Plan
Test added.