+
Skip to content

fix(biome_js_analyze): fix JsDocTypeCollectorVisitior to also walk on JsStaticMemberAssignment #6600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2025

Conversation

daivinhtran
Copy link
Contributor

This PR fixed the edge case mentioned by @arendjr in #6565 (review).

The biome playground was very helpful in identifying the missing js syntax.

Copy link

changeset-bot bot commented Jun 27, 2025

🦋 Changeset detected

Latest commit: 11440dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Jun 27, 2025
Copy link

codspeed-hq bot commented Jun 27, 2025

CodSpeed Performance Report

Merging #6600 will degrade performances by 36.51%

Comparing daivinhtran:fix-4677 (11440dc) with main (a330fcc)

Summary

❌ 1 regressions
✅ 114 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
eucjp_1600564308684076393.json[cached] 758.5 µs 1,194.6 µs -36.51%

@ematipico ematipico merged commit 853e1b5 into biomejs:main Jun 28, 2025
27 of 28 checks passed
@github-actions github-actions bot mentioned this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载