fix(biome_js_analyze): add JsExport to be walked by JsDocTypeCollectorVisitior #6565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c455d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
CodSpeed Performance ReportMerging #6565 will not alter performanceComparing Summary
|
|
I think the codspeed report is just noise. Looking into https://codspeed.io/biomejs/biome/branches/daivinhtran%3Afix-4677, the changeset commit is what causes the slowdown which shouldn't be the case. |
siketyan
approved these changes
Jun 27, 2025
Co-authored-by: Naoki Ikeguchi <me@s6n.jp>
arendjr
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5698 fixed the majority of #4677.
An unhandled edge case is exported function.
In this case, the comment belongs to
JsExportinstead ofAnyJsDeclaration. This PR fixes the edge case.