Add File Read Reliability #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into Add-File-Read-Reliability
eric-anderson
approved these changes
Feb 5, 2025
| with tempfile.TemporaryDirectory() as tmpdir, tempfile.TemporaryDirectory() as tmpdir1: | ||
|
|
||
| docs = make_docs(10) | ||
| docs.pop() |
There was a problem hiding this comment.
why not docs = make_docs(9)?
or remove the docs.pop()
There was a problem hiding this comment.
make_docs includes a MetadataDocument, removing that
f59a739
into
Add-Materialize-Read-Reliability
8 of 11 checks passed
dhruvkaliraman7
added a commit
that referenced
this pull request
Feb 6, 2025
* Add materialize read reliability * Remove extra var * Add unit test, fix signatures, add assertion checks * Lint + typo * Remove print * Modify check for _path_to_id * lint smh * Add tests, retry logic, exception handling * Address comments * Address comments, refactor to make MRR node traverse and pass through context * lint, better logging * bug fix * Allow assertions to be raised in retries * Address comments * Add File Read Reliability (#1105) * Initial dev * Remove debugging code * Remove old code which passed reliability object to context * Add exception handling after all files processed on ray, lint fix * Add unit tests * Switch to using Path Partition Filter * Add logging, fix assertions in tests * lint * refactor tests * mypy fix, make tests efficient, uniform naming convention * Remove print * Change func call from merge * Better docs and logging * Yet better docs * nits * lint smh * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces File Read Reliability (FRR), a new component that complements the Materialize Read Reliability (MRR) system. While MRR handles reliability between materialized directories, FRR focuses on the initial data ingestion phase.
Features:
Implements reliability checks for raw data reading operations.
Currently supports BinaryScan operation (file scan through the first materialization step).
Future Work:
Extend FRR support to additional scan methods, implementation will be handled in subsequent PRs.
This PR is dependent on Add Materialize Read Reliability