Add materialize read reliability #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkaliraman7
commented
Jan 3, 2025
HenryL27
reviewed
Jan 8, 2025
eric-anderson
approved these changes
Feb 4, 2025
HenryL27
approved these changes
Feb 4, 2025
eric-anderson
approved these changes
Feb 5, 2025
* Initial dev * Remove debugging code * Remove old code which passed reliability object to context * Add exception handling after all files processed on ray, lint fix * Add unit tests * Switch to using Path Partition Filter * Add logging, fix assertions in tests * lint * refactor tests * mypy fix, make tests efficient, uniform naming convention * Remove print * Change func call from merge * Better docs and logging * Yet better docs * nits * lint smh * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. MaterializeReadReliability: A new class that enables reliable batch processing of materialized files by:
Tracking already processed files
Limiting batch sizes
Supporting incremental processing through batch resets
Maintaining state between batch executions
2. Added utility functions:
name_from_docid: Custom naming function using path-based SHA256 hashes
docid_from_path: Generates document IDs(SHA 256) from path
doc_only_to_binary: Serialization helper