Deprecate Inputs.connect and handle ambiguous connections #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafacanton
approved these changes
Feb 4, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.03%
==========================================
Files 90 90
Lines 10225 10231 +6
==========================================
+ Hits 9055 9058 +3
- Misses 1170 1173 +3 |
193482e to
ef7f729
Compare
rafacanton
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Inputs.connectmethod tries to connect an object to an input pin accepting the object type.This worked when only one input accepted a certain type, and raised an error about ambiguity when several were available.
This effectively prevents from having operators with two inputs accepting a same type.
This PR changes the current behavior in two ways:
Inputs.connectmethod as deprecated in favor of explicit output-to-input connections.