Update generated code for DPF 252_daily on master #2050
Conversation
| expanded_meshed_region : MeshedRegion or MeshesContainer, optional | ||
| Mesh expanded, use if cyclic expansion is to | ||
| be done. |
There was a problem hiding this comment.
@ricardopeixotocoelho I think this may require a little clarification: what I understand is that when requesting result data expanded, you can provide a mesh to this pin so that the mesh expansion is not done by the source operator, right?
There was a problem hiding this comment.
@PProfizi Yes, you have it right. If the user provides the expanded mesh to this pin we just read it instead of expanding it in DPF
|
Waiting on #2053 |
e3e8641 to
bba76bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2050 +/- ##
==========================================
- Coverage 86.54% 84.88% -1.67%
==========================================
Files 90 90
Lines 10240 10233 -7
==========================================
- Hits 8862 8686 -176
- Misses 1378 1547 +169 |
|
Latest fix for ambiguous |
| requested_location : str, optional | ||
| Requested location nodal, elemental or | ||
| elementalnodal | ||
| read_cyclic : int, optional |
There was a problem hiding this comment.
@rafacanton @ricardopeixotocoelho is this normal? Why do we lose a pin?
There was a problem hiding this comment.
Yes, @ricardopeixotocoelho did the digging job to only support cyclic for the variables where cyclic is allowed. So this was a previous bug, basically
8c9bdf2 to
69c4e1c
Compare
69c4e1c to
3df095a
Compare
An update of generated code has been triggered either manually or by an update in the dpf-standalone repository.