+
Skip to content

Conversation

SZhengP
Copy link
Contributor

@SZhengP SZhengP commented Sep 24, 2025

  • Add NXF_VERSION: ${{ matrix.NXF_VER }} to env section in nf-test step
  • This fixes the missing environment variable that .github/actions/nf-test expects
  • The nf-test action uses ${{ env.NXF_VERSION }} for Nextflow setup but it wasn't being passed from the workflow

PR checklist

  • [ x] This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

- Add NXF_VERSION: ${{ matrix.NXF_VER }} to env section in nf-test step
- This fixes the missing environment variable that .github/actions/nf-test expects
- The nf-test action uses ${{ env.NXF_VERSION }} for Nextflow setup but it wasn't being passed from the workflow
@SZhengP SZhengP requested a review from Copilot September 24, 2025 11:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a missing environment variable in the nf-test workflow by adding the NXF_VERSION environment variable that the nf-test action expects for proper Nextflow setup.

  • Adds NXF_VERSION: ${{ matrix.NXF_VER }} to the environment variables section of the nf-test workflow step
  • Ensures the nf-test action receives the required Nextflow version information for proper execution

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SZhengP SZhengP requested a review from maxulysse September 24, 2025 11:56
@SZhengP SZhengP requested a review from mirpedrol September 24, 2025 11:56
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.24%. Comparing base (abf4c30) to head (2ed2320).
⚠️ Report is 5 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu changed the title Fix: Add NXF_VERSION environment variable to nf-test workflow Template: Fix: Add NXF_VERSION environment variable to nf-test workflow Sep 29, 2025
@mashehu
Copy link
Contributor

mashehu commented Sep 29, 2025

@nf-core-bot changelog

@SZhengP SZhengP merged commit a9bd678 into dev Sep 29, 2025
116 checks passed
@SZhengP SZhengP deleted the fix/add-nxf-version-env branch September 29, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载