-
Notifications
You must be signed in to change notification settings - Fork 214
Add topics
to the template + update linting
#3779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvnieuwk
wants to merge
27
commits into
nf-core:dev
Choose a base branch
from
nvnieuwk:feat/topics
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8fc05a5
update module and subworkflow template
nvnieuwk de4908f
[automated] Update CHANGELOG.md
nf-core-bot 4d94180
Merge branch 'dev' into feat/topics
nvnieuwk c48f7ac
also emit versions
nvnieuwk b534065
Merge branch 'dev' into feat/topics
nvnieuwk 62ea7f0
add main.nf linting for topics
nvnieuwk e490c68
Update modules lint --fix to work with eval
nvnieuwk 5f1af90
Update nf_core/module-template/main.nf
nvnieuwk 1c6f6c9
versions emit should now contain the tool name
nvnieuwk a749470
Merge branch 'feat/topics' of github.com:nvnieuwk/tools into feat/topics
nvnieuwk 6cb96ee
linting fixes for new versions topics
nvnieuwk a4d8aac
Merge branch 'dev' into feat/topics
nvnieuwk 5a31432
add topic handling to the main workflow
nvnieuwk 0e726e1
pre-commit
nvnieuwk 249c8eb
add versions file as valid topic output + fix meta yaml template
nvnieuwk 6b02333
update meta yaml versions output on module create
nvnieuwk f9f42a1
Merge branch 'dev' into feat/topics
nvnieuwk 3095597
pre-commit
nvnieuwk 0eea1b4
pre-commit
nvnieuwk 2d49346
sort versions output
nvnieuwk c7be4d7
try to add versions on module creation
nvnieuwk 5e1928d
update topics structure + added a check for empty input and output
nvnieuwk 53f356c
Merge branch 'dev' into feat/topics
nvnieuwk b150244
fix wrongly resolved merge conflict
nvnieuwk 7c954d6
fix module create tests + pre-commit
nvnieuwk fbe8f63
fix usage of versions string
nvnieuwk 58d4ba7
Merge branch 'dev' into feat/topics
nvnieuwk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add a new section
topics