+
Skip to content

Conversation

Joon-Klaps
Copy link
Contributor

Noticed that prettier was checking all content in the (residual) .nf-test dirs.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.23%. Comparing base (4164503) to head (591ee86).
⚠️ Report is 3 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joon-Klaps Joon-Klaps requested a review from mashehu September 26, 2025 08:47
@mashehu
Copy link
Contributor

mashehu commented Sep 26, 2025

Nice catch, thanks!
Could you please add the template variable if clause so it is only added if people use nf-test?

@Joon-Klaps
Copy link
Contributor Author

The variable to use is nf-test for that currently, however jinja doesn't like when there are - in its variables.
Meaning the nf-test var should be renamed to nf_test but this is not the scope of this PR.

@Joon-Klaps Joon-Klaps merged commit abf4c30 into dev Sep 26, 2025
116 checks passed
@Joon-Klaps Joon-Klaps deleted the Joon-Klaps-patch-1 branch September 26, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载