+
Skip to content

Conversation

jpfeuffer
Copy link
Contributor

@jpfeuffer jpfeuffer commented Sep 22, 2025

Updated multiqc to 1.31

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.33%. Comparing base (37418ee) to head (d12381a).
⚠️ Report is 12 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu changed the title [Update] multiqc 1.31 Template Update multiqc to 1.31 Sep 22, 2025
@mashehu mashehu changed the title Template Update multiqc to 1.31 Template: Update multiqc to 1.31 Sep 22, 2025
@mashehu
Copy link
Contributor

mashehu commented Sep 22, 2025

@nf-core-bot changelog

@mashehu
Copy link
Contributor

mashehu commented Sep 22, 2025

@nf-core-bot update snapshots

@jpfeuffer
Copy link
Contributor Author

Oh nice. Didn't know that command! thx

@mashehu
Copy link
Contributor

mashehu commented Sep 22, 2025

ah, it's the wrong snapshots, sorry, was too long away 😁

@mashehu
Copy link
Contributor

mashehu commented Sep 22, 2025

@nf-core-bot update template snapshots

@jpfeuffer
Copy link
Contributor Author

@mashehu Is the linting error about the mismatch of local vs remote module to be expected? Or do I need to change more?

@jpfeuffer
Copy link
Contributor Author

I guess my question was: since it probably checks against the main branch where the update was not yet applied, isn't it expected that this linting step fails?
Or how does this linting comparison step work otherwise?

@mashehu
Copy link
Contributor

mashehu commented Oct 1, 2025

it checks against the modules repo, where it is already updated, no?

@mirpedrol
Copy link
Member

I think the test is failing because the modules.json file from the pipeline template should also be updated with the proper hash for the version of the module.

@mashehu
Copy link
Contributor

mashehu commented Oct 1, 2025

oops, will do that

@mashehu
Copy link
Contributor

mashehu commented Oct 1, 2025

@nf-core-bot update snapshots

@jpfeuffer
Copy link
Contributor Author

Haha, just saw that too
Screenshot 2025-10-01 at 11 38 42

@mashehu mashehu added this to the 3.4.0 milestone Oct 6, 2025
@mashehu mashehu enabled auto-merge October 6, 2025 13:21
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally, sorry that this took sooo long

@mashehu mashehu merged commit 850944f into dev Oct 7, 2025
116 checks passed
@mashehu mashehu deleted the update/mqc1.31 branch October 7, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载