+
Skip to content

Conversation

muffato
Copy link
Member

@muffato muffato commented Sep 13, 2025

Hello,

One of our pipelines had a faulty subworkflow patch and I investigated why it wasn't reported by nf-core pipelines lint.

The main problem is that the LookupError was ignored. I don't know what "This error is already reported by subworkflow_patch" is referring to. It certainly wasn't working ! So here I propose to directly log an error.

The other problem is I think unrelated, but I found that while debugging. As far as I can tell, self.meta cannot be False. It can be None, though.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@muffato muffato self-assigned this Sep 13, 2025
@muffato muffato added bug Something isn't working subworkflows labels Sep 13, 2025
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.33%. Comparing base (26b7b10) to head (b682f79).
⚠️ Report is 29 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@muffato muffato changed the title Subworkflow patch Linting of patched subworkflows Sep 13, 2025
@muffato muffato marked this pull request as ready for review September 13, 2025 23:42
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@muffato muffato merged commit 7ba3e5e into dev Sep 30, 2025
116 checks passed
@muffato muffato deleted the subworkflow_patch branch September 30, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working subworkflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载