+
Skip to content

Bump/nf schema 2.5.1 #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 10, 2025
Merged

Bump/nf schema 2.5.1 #3743

merged 19 commits into from
Sep 10, 2025

Conversation

nvnieuwk
Copy link
Contributor

@nvnieuwk nvnieuwk commented Sep 2, 2025 •
edited
Loading

This PR bumps nf-schema to the new 2.5.1 version.

The help message and parameter summary creation have also been updated to ensure compatibility with future nextflow versions. Currently we used unsupported config logic that would fail once the strict config syntax will be enforced. This logic has now been moved to the utils subworkflow using the updated paramsHelp function.

mirpedrol
mirpedrol approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I made some modifications in the jinja2 lines, to avoid empty lines with spaces when we render the template

@nvnieuwk nvnieuwk changed the title Bump/nf schema 2.5.0 Bump/nf schema 2.5.1 Sep 10, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.23%. Comparing base (5ec33a0) to head (0e3b0f0).
⚠️ Report is 20 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nvnieuwk
Copy link
Contributor Author

@mirpedrol are you okay with this being merged?

@mirpedrol
Copy link
Member

Yes, fine for me.
We should change the CI protection once this is merged, make 25.04.0 required instead of 24.10.5

@nvnieuwk
Copy link
Contributor Author

Can I force merge? The check seems to be stuck but all tests pass

@mirpedrol
Copy link
Member

I have modified the branch protection rules, should be OK now

@mirpedrol
Copy link
Member

We should also update the Nextflow version in MakeTestWorkflow no?

@nvnieuwk
Copy link
Contributor Author

nvnieuwk commented Sep 10, 2025 •
edited
Loading

We should also update the Nextflow version in MakeTestWorkflow no?

Good catch, should be okay now

@nvnieuwk
Copy link
Contributor Author

I have modified the branch protection rules, should be OK now

Seems like you will need to do it again 😁

@mirpedrol
Copy link
Member

done :)

@nvnieuwk nvnieuwk merged commit 26b7b10 into nf-core:dev Sep 10, 2025
116 checks passed
@nvnieuwk nvnieuwk deleted the bump/nf-schema-2.5.0 branch September 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nvnieuwk @mirpedrol @maxulysse
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载