-
Notifications
You must be signed in to change notification settings - Fork 214
Replace arm profile with arm64 and emulate_amd64 profiles #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: The `arm` profile has been renamed to `arm64` and now provides native ARM64 support using Wave containers instead of x86 emulation. - Replace `arm` profile with `arm64` profile for native ARM64 execution - Add `emulate_amd64` profile for users who need x86 emulation on ARM hardware - The `arm64` profile works universally on Apple Silicon, AWS Graviton, and other ARM64 platforms - Users must update: `-profile arm` → `-profile arm64` (for native) or `-profile emulate_amd64` (for emulation) Fixes #3536 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Can we add a deprecation log message for people using the old profile? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
While I agree that a deprecation message would be nice, I think it adds too much unnecessary code to the pipeline template, so I wouldn't add it here. We must make sure to mention this in the release blog post though!
That might have worked, but the new strict config parser won't allow it(according to @ewels ). So just the warning message "there is no arm profile" will hopefully make them go look. |
The
arm
profile has been renamed toarm64
and now provides native ARM64 support using Wave containers instead of x86 emulation.arm
profile witharm64
profile for native ARM64 executionemulate_amd64
profile for users who need x86 emulation on ARM hardwarearm64
profile works universally on Apple Silicon, AWS Graviton, and other ARM64 platforms-profile arm
→-profile arm64
(for native) or-profile emulate_amd64
(for emulation). This should only be users on apple silicon.Hopefully users will be happy to migrate, it's a pretty big speed up.
Before
After