+
Skip to content

don't read param expressions with spaces as params #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mirpedrol
Copy link
Member

Close #3672

https://regex101.com/r/xuh0TQ/1
The expressions that contain spaces are not read as if they were param variables.

@mirpedrol mirpedrol requested review from maxulysse and mashehu July 10, 2025 08:38
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for this so we don't run into it in the future?

@mirpedrol
Copy link
Member Author

Maybe add a test for this so we don't run into it in the future?

It's a regular expression, not sure we need a test for this. There is no way we can know what code people is going to add that will not match our regex

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (28b76a4) to head (587b816).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu
Copy link
Contributor

mashehu commented Jul 10, 2025

i just want to basically have a list of cases this regex should cover so we now we don't break anything if we for example can replace this with reftrace

@maxulysse
Copy link
Member

spaces, not equals?

@mirpedrol
Copy link
Member Author

spaces, not equals?

My description was not very good 😅 The error happened when there was an equal but I am now fixing it by not considering any param name that contains spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载