+
Skip to content

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented May 20, 2025

No description provided.

@mashehu mashehu requested review from mirpedrol and nvnieuwk May 20, 2025 13:36
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is 2.4.2, why not bump to that version?

@mirpedrol
Copy link
Member

The current minimal NF version in the pipelines is 24.04.2, and the minimal required for nf-schema is 24.10.0. It would be good to maintain the minimal version for a while. Or does the new nf-schema version contain critical fixes?

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (75d8c83) to head (f46e2e7).
Report is 3 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nvnieuwk
Copy link
Contributor

Not immediately, that version only breaks when people use the workflow output definitions preview, but they should just manually bump in that case

@mashehu mashehu merged commit dd6c4bf into dev May 20, 2025
97 checks passed
@mashehu mashehu deleted the update-nf-schema branch May 20, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载