-
Notifications
You must be signed in to change notification settings - Fork 214
Template: Don't fail CI on latest-everything
#3543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! But I am not sure this is going to work as is, I think we are only able to comment on a PR when the action trigger is pull_request_target
, that's why we have a different YAML file for the other actions such as branch protection or linting
good point. In the docs they mention adding:
have we tested if that works? |
I did go through the rabbit hole some time ago and the only solution was to create a separate yaml file, but worth giving it a try with the testpipeline 👍 |
looks like it works: nf-core/testpipeline#109 (comment) |
or does it need to come from a fork. one second |
ah, you were right 😞 |
latest-everything
, post a comment insteadlatest-everything
@nf-core-bot changelog |
This change was introduced with 511126a so the PR can be closed |
Sorry, I didn't notice this was in the nf-test.yml file! Reopening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some changes removing the lines of code that we don't need since we are not trying to write a comment to the PR. Once this is done, LGTM!
@mashehu what is the status of this PR? I think the downgrade of nf-schema is not necessary, but printing the summary of tests is still relevant |
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
16703c4
to
3aa61f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise LGTM!
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
No description provided.