+
Skip to content

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Apr 24, 2025

No description provided.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (a1772ab) to head (d58d4a7).
Report is 1 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! But I am not sure this is going to work as is, I think we are only able to comment on a PR when the action trigger is pull_request_target, that's why we have a different YAML file for the other actions such as branch protection or linting

@mashehu
Copy link
Contributor Author

mashehu commented Apr 24, 2025

Good idea! But I am not sure this is going to work as is, I think we are only able to comment on a PR when the action trigger is pull_request_target, that's why we have a different YAML file for the other actions such as branch protection or linting

good point. In the docs they mention adding:

permissions:
  pull-requests: write

have we tested if that works?

@mirpedrol
Copy link
Member

I did go through the rabbit hole some time ago and the only solution was to create a separate yaml file, but worth giving it a try with the testpipeline 👍

@mashehu
Copy link
Contributor Author

mashehu commented Apr 24, 2025

looks like it works: nf-core/testpipeline#109 (comment)

@mashehu
Copy link
Contributor Author

mashehu commented Apr 24, 2025

or does it need to come from a fork. one second

@mashehu
Copy link
Contributor Author

mashehu commented Apr 24, 2025

ah, you were right 😞

@mashehu mashehu changed the title Template: Don't fail CI on latest-everything, post a comment instead Template: Don't fail CI on latest-everything Apr 29, 2025
@mashehu
Copy link
Contributor Author

mashehu commented Apr 29, 2025

@nf-core-bot changelog

@mirpedrol
Copy link
Member

This change was introduced with 511126a so the PR can be closed

@mirpedrol mirpedrol closed this Apr 30, 2025
@mirpedrol
Copy link
Member

Sorry, I didn't notice this was in the nf-test.yml file! Reopening

@mirpedrol mirpedrol reopened this Apr 30, 2025
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some changes removing the lines of code that we don't need since we are not trying to write a comment to the PR. Once this is done, LGTM!

@mirpedrol
Copy link
Member

@mashehu what is the status of this PR? I think the downgrade of nf-schema is not necessary, but printing the summary of tests is still relevant

@mashehu mashehu force-pushed the disable-latest-everything branch from 16703c4 to 3aa61f4 Compare June 30, 2025 07:35
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise LGTM!

Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@mashehu mashehu enabled auto-merge (squash) June 30, 2025 14:47
@mashehu mashehu merged commit 68661d3 into nf-core:dev Jun 30, 2025
97 of 98 checks passed
@mashehu mashehu deleted the disable-latest-everything branch June 30, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载